Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup GoReturnsBearTest by removing unnecessary information #44

Closed
sils opened this issue Feb 21, 2016 · 14 comments
Closed

Cleanup GoReturnsBearTest by removing unnecessary information #44

sils opened this issue Feb 21, 2016 · 14 comments

Comments

@sils
Copy link
Member

sils commented Feb 21, 2016

From @sudheesh001 on February 15, 2016 19:48

the GoReturnsBearTest contains the following which needs to be removed

a = ['import "errors"', '',
     'func F() (*MyType, int, error) { return nil, 0, errors.New("foo") }']
b = ['package main', '', 'import "os"', '',
     'func main() {', '\tf, _ := os.Open("foo")', '}']

Put the good_files in the same line like the bad_files

(good_file1,
     good_file2,),
    (bad_file1, bad_file2,))

Also correct GoReturnsBear's run() documentation to show using goreturns instead of using gofmt

difficulty/newcomer

Copied from original issue: coala/coala#1516

@sils
Copy link
Member Author

sils commented Feb 21, 2016

From @satyamamrev on February 16, 2016 7:39

I want to contribute to this

@sils
Copy link
Member Author

sils commented Feb 21, 2016

@sils
Copy link
Member Author

sils commented Feb 21, 2016

From @AbdealiJK on February 21, 2016 11:22

@satyamamrev is doing this in coala/coala#1533

@sils1297 he needs to be added to the org

@sils
Copy link
Member Author

sils commented Feb 21, 2016

Invitation pending to satyamamrev and hypothesist

2016-02-21 12:22 GMT+01:00 AbdealiJK notifications@github.com:

@satyamamrev https://github.com/satyamamrev is doing this in #1533
coala/coala#1533

@sils1297 https://github.com/sils1297 he needs to be added to the org


Reply to this email directly or view it on GitHub
coala/coala#1516 (comment)
.

@sils
Copy link
Member Author

sils commented Feb 21, 2016

Assigning @hypothesist since he accepted the invitation.

@Adrianzatreanu
Copy link
Contributor

unassigning due to numerous contributions?

@sarthak268
Copy link

assign me this

@Adrianzatreanu
Copy link
Contributor

unassigning due to inactivity

@mihai-burduselu
Copy link

Assign me this!

1 similar comment
@OctavianGuzu
Copy link

Assign me this!

@sils
Copy link
Member Author

sils commented Nov 19, 2016

Both of you are already assigned to another newcomer issues. We only have a limited number of them and they take a lot of time to review etc, consier doing a coala.io/low issue instead if you want more!

@ghost
Copy link

ghost commented Dec 7, 2016

I would like to get assigned to this.

@sils sils assigned ghost Dec 7, 2016
@sils
Copy link
Member Author

sils commented Dec 7, 2016

there you go

@ghost
Copy link

ghost commented Dec 7, 2016

I need some clarification

a = ['import "errors"', '',
'func F() (*MyType, int, error) { return nil, 0, errors.New("foo") }']
b = ['package main', '', 'import "os"', '',
'func main() {', '\tf, _ := os.Open("foo")', '}']

Instead of 'a' and 'b' variable names are 'good_file1' and 'good_file2'

(1) Should I remove those lines ?

@rultor rultor closed this as completed in 9537931 Dec 18, 2016
ashwani99 pushed a commit to ashwani99/coala-bears that referenced this issue Dec 19, 2016
Ensures that 'good_file1' and 'good_file2' variables
are aligned properly in the same line.

Closes coala#44
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
Ensures that 'good_file1' and 'good_file2' variables
are aligned properly in the same line.

Closes coala#44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants