bears/haskell: Add GhcModBear #1223

vijeth-aradhya · 2016-12-30T00:03:21Z

Add GhcModBear for syntax checking
for Haskell files (.hs)

Closes #297

gitmate-bot · 2016-12-30T00:03:33Z

Thanks for your contribution!

Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.

I have rebased properly. Please see this for a tutorial.
I have gone through the commit guidelines and I've followed them:
I have followed the guidelines for the commit shortlog.
I have followed the guidelines for the commit body.
I have included the issue URL.
I have used the Fixes keyword if the commit fixes a real bug and the Closes keyword if it adds a feature/enhancement. See more here.
I have run all the tests and they all pass. That includes that all CI (below) is green - if GitMate issues appear you will have to amend your commits, pushing new commits on top is not sufficient!

As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!

Nosferatul · 2016-12-30T00:08:45Z

bears/haskell/GhcModBear.py

+    """
+    Syntax checking with ghc for haskell files (.hs)
+
+    Check out https://hackage.haskell.org/package/ghc-mod for more information!


the link should be between <>

Alright! 😄

Nosferatul · 2016-12-30T00:11:04Z

bears/haskell/GhcModBear.py

+                     r'(?P<message>.+)')
+class GhcModBear:
+    """
+    Syntax checking with ghc for haskell files (.hs)


I'm not sure if we need (.hs) here

Hm I need to specify the file extension
Any ideas on how? []?

Any reason why CircleCI is failing? :/

sims1253 · 2016-12-30T15:26:28Z

bears/haskell/GhcModBear.py

+    Syntax checking with ghc for haskell files.
+
+    See <https://hackage.haskell.org/package/ghc-mod for more information>
+    for more information!


double "for more information"

sims1253 · 2016-12-30T15:30:44Z

your builds are failing :(

Mixih · 2016-12-30T19:01:47Z

tests/haskell/GhcModBearTest.py

+main = do
+    print(lastButOne(["asd", "ASd"]))
+"""
+


hmm let's use a test class with a generate_skip_decorator so we know whether it's skipping because of a depend or some internal logic error. See http://api.coala.io/en/latest/Developers/Testing_Bears.html

actually that is unnecessary skipdecorator is built in to that test class... Just install it properly in ci

No really necessary IMO.

Mixih · 2017-01-06T00:39:21Z

bear-requirements.txt

@@ -29,3 +29,4 @@ vim-vint~=0.3.10
 vulture~=0.10.0
 yamllint~=1.5
 yapf~=0.14.0
+dependency_management~=0.2.0


Please don't add this, it can cause all kinds of dependency problems as we've already inherited it from coala. I see you have a pull there, Please remove this when it gets accepted.

sils · 2017-01-06T08:47:42Z

@vijeth-aradhya you'll have to update coala in requirements.txt to version >=0.10.0.dev20170106003439 to pick up the change you did

sils · 2017-01-06T08:49:29Z

bears/haskell/GhcModBear.py

+    AUTHORS = {'The coala developers'}
+    AUTHORS_EMAILS = {'coala-devel@googlegroups.com'}
+    LICENSE = 'AGPL-3.0'
+    ASCIINEMA_URL = 'https://asciinema.org/a/97863'


FWIW it looks like there's spaces missing in the message, is that like that in the output of the tool or a bug of ours somewhere?

spaces missing?! What do you mean :o

from the literal ‘3’In the first no space before In

hmm i'll check it out now 👍

This is ghc-7.10.3 output on my local machine for the first testfile

/GhcModBearTests/testfile1.hs:2:17: No instance for (Num String) arising from the literal ‘3’ In the first argument of ‘putStrLn’, namely ‘3’ In the expression: putStrLn 3 In an equation for ‘main’: main = putStrLn 3

Looks to me that wherever there is \n, it's just joining the strings

can you file an issue for linter in coala?

It'll be nice if we make it prettier I guess 👍 Hmm anyway we can add a \n there?!

Oh wait my bad, that is ghc output, this is ghc-mod-5.6.0 output
There is nothing wrong in our Linter - it's their output which is like that 👍

~/GhcModBearTests/testfile1.hs:2:17:No instance for (Num String) arising from the literal ‘3’In the first argument of ‘putStrLn’, namely ‘3’In the expression: putStrLn 3In an equation for ‘main’: main = putStrLn 3

cool, file a bug upstream ok?

Yup I did, here 👍

sils · 2017-01-06T08:53:08Z

tests are much better, I feel like the extra round of review really added some quality here 👍 I hope this wasn't too frustrating :/. If you change the requirements as indicated above I think it'll work and we can really finally merge it.

Add ghc-mod feature to coala for syntax checking for haskell files (.hs) Closes coala#297

Upgradation of dependency_management version from 0.1.7 to 0.2.0 is major modification here Related to coala#297

gitmate-bot · 2017-01-06T10:09:02Z

Comment on 11845d8.

Shortlog of HEAD commit isn't in imperative mood! Bad words are 'Updated'

GitCommitBear, severity NORMAL, section commit.

vijeth-aradhya · 2017-01-06T10:58:13Z

Travis still weirdly failing .. 😞

jayvdb · 2017-04-28T08:30:33Z

Completed at #1267

gitmate-bot added process/pending review size/M labels Dec 30, 2016

Nosferatul reviewed Dec 30, 2016

View reviewed changes

vijeth-aradhya force-pushed the master branch 3 times, most recently from 237dcbe to 6237d68 Compare December 30, 2016 00:18

vijeth-aradhya mentioned this pull request Dec 30, 2016

coalib: Fix affected_code placeholder render coala/coala#3394

Merged

6 tasks

sims1253 reviewed Dec 30, 2016

View reviewed changes

sims1253 added process/wip and removed process/pending review labels Dec 30, 2016

vijeth-aradhya force-pushed the master branch from 6237d68 to c42697e Compare December 30, 2016 18:47

gitmate-bot added process/pending review review carefully! and removed process/wip labels Dec 30, 2016

vijeth-aradhya force-pushed the master branch from c42697e to 13d35d8 Compare December 30, 2016 18:49

Mixih reviewed Dec 30, 2016

View reviewed changes

Mixih added process/wip and removed process/pending review labels Dec 30, 2016

vijeth-aradhya force-pushed the master branch from 13d35d8 to 9a8e974 Compare December 30, 2016 19:21

gitmate-bot added process/pending review and removed process/wip labels Dec 30, 2016

vijeth-aradhya force-pushed the master branch 7 times, most recently from 17c167f to 1445440 Compare December 30, 2016 22:17

gitmate-bot added process/pending review and removed process/wip labels Jan 5, 2017

Mixih reviewed Jan 6, 2017

View reviewed changes

Mixih added process/wip and removed process/pending review labels Jan 6, 2017

vijeth-aradhya force-pushed the master branch from 72e011f to 3e63fb4 Compare January 6, 2017 06:53

gitmate-bot added process/pending review and removed process/wip labels Jan 6, 2017

vijeth-aradhya force-pushed the master branch from 3e63fb4 to cfb67fd Compare January 6, 2017 07:32

sils added process/wip status/blocked process/pending review and removed process/pending review process/wip status/blocked labels Jan 6, 2017

sils reviewed Jan 6, 2017

View reviewed changes

coala-bot added process/wip and removed process/pending review labels Jan 6, 2017

bears/haskell: Add GhcModBear

10ed5d9

Add ghc-mod feature to coala for syntax checking for haskell files (.hs) Closes coala#297

vijeth-aradhya force-pushed the master branch from cfb67fd to 11845d8 Compare January 6, 2017 10:08

gitmate-bot added process/pending review and removed process/wip labels Jan 6, 2017

requirements.txt: Update coala dev version

c9dc558

Upgradation of dependency_management version from 0.1.7 to 0.2.0 is major modification here Related to coala#297

vijeth-aradhya force-pushed the master branch from 11845d8 to c9dc558 Compare January 6, 2017 10:09

vijeth-aradhya closed this Jan 6, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bears/haskell: Add GhcModBear #1223

bears/haskell: Add GhcModBear #1223

vijeth-aradhya commented Dec 30, 2016

gitmate-bot commented Dec 30, 2016

Nosferatul Dec 30, 2016

vijeth-aradhya Dec 30, 2016

Nosferatul Dec 30, 2016

vijeth-aradhya Dec 30, 2016

vijeth-aradhya Dec 30, 2016

sims1253 Dec 30, 2016

sims1253 commented Dec 30, 2016

Mixih Dec 30, 2016 •

edited

Loading

Mixih Dec 30, 2016 •

edited

Loading

aptrishu Jan 2, 2017

Mixih Jan 6, 2017

sils commented Jan 6, 2017

sils Jan 6, 2017

vijeth-aradhya Jan 6, 2017

sils Jan 6, 2017

vijeth-aradhya Jan 6, 2017

vijeth-aradhya Jan 6, 2017

sils Jan 6, 2017

vijeth-aradhya Jan 6, 2017

vijeth-aradhya Jan 6, 2017 •

edited

Loading

sils Jan 6, 2017

vijeth-aradhya Jan 6, 2017

sils commented Jan 6, 2017

gitmate-bot commented Jan 6, 2017

vijeth-aradhya commented Jan 6, 2017

jayvdb commented Apr 28, 2017

bears/haskell: Add GhcModBear #1223

bears/haskell: Add GhcModBear #1223

Conversation

vijeth-aradhya commented Dec 30, 2016

gitmate-bot commented Dec 30, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sims1253 commented Dec 30, 2016

Mixih Dec 30, 2016 • edited Loading

Choose a reason for hiding this comment

Mixih Dec 30, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sils commented Jan 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vijeth-aradhya Jan 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sils commented Jan 6, 2017

gitmate-bot commented Jan 6, 2017

vijeth-aradhya commented Jan 6, 2017

jayvdb commented Apr 28, 2017

Mixih Dec 30, 2016 •

edited

Loading

Mixih Dec 30, 2016 •

edited

Loading

vijeth-aradhya Jan 6, 2017 •

edited

Loading