bears/c_languages: Add OClintBear #2149

bhavishyagopesh · 2017-12-04T08:02:29Z

Adds OClintBear that provides static code analysis for C, C++ and
Objective-C.

Closes #1953

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

I read the commit guidelines and I've followed
them.
I ran coala over my code locally. (All commits have to pass
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

pick up any PR at https://coala.io/review
review it (check https://coala.io/reviewing for more info)
if you are sure that it needs work, use cobot mark wip <URL> to get it out
of the review queue.

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

gitmate-bot · 2017-12-04T08:02:51Z

tests/c_languages/OClintBearTest.py

+    valid_files=(bad_file, good_file),
+    invalid_files=(),
+    settings={'oclint_cli_options': '-max-priority-1=2'})
+


The code does not comply to PEP8.

Origin: PEP8Bear, Section: autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp_di5qvhc/tests/c_languages/OClintBearTest.py +++ b/tmp/tmp_di5qvhc/tests/c_languages/OClintBearTest.py @@ -34,4 +34,3 @@ valid_files=(bad_file, good_file), invalid_files=(), settings={'oclint_cli_options': '-max-priority-1=2'}) -

gitmate-bot · 2017-12-04T08:02:52Z

tests/c_languages/OClintBearTest.py

+    valid_files=(bad_file, good_file),
+    invalid_files=(),
+    settings={'oclint_cli_options': '-max-priority-1=2'})
+


W391 blank line at end of file

Origin: PycodestyleBear (W391), Section: autopep8.

gitmate-bot · 2017-12-04T08:02:53Z

bears/c_languages/OClintBear.py

+    @staticmethod
+    def create_arguments(filename, file, config_file,
+                         oclint_cli_options: str=''):
+


The code does not comply to PEP8.

Origin: PEP8Bear, Section: autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp_di5qvhc/bears/c_languages/OClintBear.py +++ b/tmp/tmp_di5qvhc/bears/c_languages/OClintBear.py @@ -21,7 +21,6 @@ @staticmethod def create_arguments(filename, file, config_file, oclint_cli_options: str=''): - """ :param oclint_cli_options: Any other flags you wish to pass to oclint. """

gitmate-bot · 2017-12-04T08:08:49Z

tests/c_languages/OClintBearTest.py

+    OClintBear,
+    valid_files=(bad_file, good_file),
+    invalid_files=(),
+    settings={'oclint_cli_options': '-max-priority-1=2'})


Line contains following spacing inconsistencies:

No newline at EOF.

Origin: SpaceConsistencyBear, Section: python.

The issue can be fixed by applying the following patch:

--- a/tmp/tmphvy4zy6p/tests/c_languages/OClintBearTest.py +++ b/tmp/tmphvy4zy6p/tests/c_languages/OClintBearTest.py @@ -33,4 +33,4 @@ OClintBear, valid_files=(bad_file, good_file), invalid_files=(), - settings={'oclint_cli_options': '-max-priority-1=2'})+ settings={'oclint_cli_options': '-max-priority-1=2'})

gitmate-bot · 2017-12-04T08:08:50Z

tests/c_languages/OClintBearTest.py

+    OClintBear,
+    valid_files=(bad_file, good_file),
+    invalid_files=(),
+    settings={'oclint_cli_options': '-max-priority-1=2'})


The code does not comply to PEP8.

Origin: PEP8Bear, Section: autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmphvy4zy6p/tests/c_languages/OClintBearTest.py +++ b/tmp/tmphvy4zy6p/tests/c_languages/OClintBearTest.py @@ -33,4 +33,4 @@ OClintBear, valid_files=(bad_file, good_file), invalid_files=(), - settings={'oclint_cli_options': '-max-priority-1=2'})+ settings={'oclint_cli_options': '-max-priority-1=2'})

gitmate-bot · 2017-12-04T08:08:51Z

tests/c_languages/OClintBearTest.py

+    OClintBear,
+    valid_files=(bad_file, good_file),
+    invalid_files=(),
+    settings={'oclint_cli_options': '-max-priority-1=2'})


W292 no newline at end of file

Origin: PycodestyleBear (W292), Section: autopep8.

newbazz

Always run coala before making a PR.

bhavishyagopesh · 2017-12-04T11:46:37Z

@jayvdb / @Makman2 Is it failing due to absence of oclint or test coverage is really limited?
also I guess ssss means skip...

khanchi97

It is failing because test coverage couldn't reach to 100% means you are missing some cases.

bhavishyagopesh · 2017-12-05T07:37:55Z

@khanchi97 yeah, but it could be also because there is no oclint executable present.

gitmate-bot · 2017-12-07T16:27:05Z

tests/c_languages/OClintBearTest.py

+    GoLintBear,
+    valid_files=(good_file),
+    invalid_files=(),
+    settings={'oclint_cli_options': '-disable-rule=GOtoStatement'})


Line contains following spacing inconsistencies:

No newline at EOF.

Origin: SpaceConsistencyBear, Section: python.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp4o5fabpp/tests/c_languages/OClintBearTest.py +++ b/tmp/tmp4o5fabpp/tests/c_languages/OClintBearTest.py @@ -32,4 +32,4 @@ GoLintBear, valid_files=(good_file), invalid_files=(), - settings={'oclint_cli_options': '-disable-rule=GOtoStatement'})+ settings={'oclint_cli_options': '-disable-rule=GOtoStatement'})

gitmate-bot · 2017-12-07T16:27:06Z

tests/c_languages/OClintBearTest.py

+    GoLintBear,
+    valid_files=(good_file),
+    invalid_files=(),
+    settings={'oclint_cli_options': '-disable-rule=GOtoStatement'})


The code does not comply to PEP8.

Origin: PEP8Bear, Section: autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp4o5fabpp/tests/c_languages/OClintBearTest.py +++ b/tmp/tmp4o5fabpp/tests/c_languages/OClintBearTest.py @@ -32,4 +32,4 @@ GoLintBear, valid_files=(good_file), invalid_files=(), - settings={'oclint_cli_options': '-disable-rule=GOtoStatement'})+ settings={'oclint_cli_options': '-disable-rule=GOtoStatement'})

gitmate-bot · 2017-12-07T16:27:08Z

tests/c_languages/OClintBearTest.py

+    GoLintBear,
+    valid_files=(good_file),
+    invalid_files=(),
+    settings={'oclint_cli_options': '-disable-rule=GOtoStatement'})


W292 no newline at end of file

Origin: PycodestyleBear (W292), Section: autopep8.

Adds `OClintBear` that provides static code analysis for C, C++ and Objective-C. Closes coala#1953

newbazz

Read about pytest coverage and add some test cases ;P and rebase as well ;)

gitmate-bot added process/pending review size/XS area/lintbears bear proposal difficulty/low labels Dec 4, 2017

gitmate-bot assigned prachi1210 Dec 4, 2017

gitmate-bot reviewed Dec 4, 2017

View reviewed changes

bhavishyagopesh force-pushed the fix/issue-1953 branch from 9053241 to a012a49 Compare December 4, 2017 08:08

gitmate-bot reviewed Dec 4, 2017

View reviewed changes

bhavishyagopesh force-pushed the fix/issue-1953 branch 2 times, most recently from 8c6a7fa to ff5d0ef Compare December 4, 2017 08:40

newbazz suggested changes Dec 4, 2017

View reviewed changes

bhavishyagopesh force-pushed the fix/issue-1953 branch from ff5d0ef to f064731 Compare December 4, 2017 11:14

gitmate-bot assigned bhavishyagopesh and unassigned prachi1210 Dec 4, 2017

khanchi97 reviewed Dec 5, 2017

View reviewed changes

bhavishyagopesh force-pushed the fix/issue-1953 branch 5 times, most recently from 86a6ad3 to 201b40b Compare December 7, 2017 16:26

gitmate-bot reviewed Dec 7, 2017

View reviewed changes

bhavishyagopesh force-pushed the fix/issue-1953 branch 5 times, most recently from 2ca29f5 to 0a212ea Compare December 8, 2017 15:31

bears/c_languages: Add OClintBear

0a212ea

Adds `OClintBear` that provides static code analysis for C, C++ and Objective-C. Closes coala#1953

gitmate-bot added the status/STALE label Dec 16, 2017

newbazz suggested changes Jan 5, 2018

View reviewed changes

Makman2 added process/wip and removed process/pending review labels Jan 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bears/c_languages: Add OClintBear #2149

bears/c_languages: Add OClintBear #2149

bhavishyagopesh commented Dec 4, 2017 •

edited

gitmate-bot Dec 4, 2017

gitmate-bot Dec 4, 2017

gitmate-bot Dec 4, 2017

gitmate-bot Dec 4, 2017

gitmate-bot Dec 4, 2017

gitmate-bot Dec 4, 2017

newbazz left a comment

bhavishyagopesh commented Dec 4, 2017 •

edited

khanchi97 left a comment

bhavishyagopesh commented Dec 5, 2017

gitmate-bot Dec 7, 2017

gitmate-bot Dec 7, 2017

gitmate-bot Dec 7, 2017

newbazz left a comment

bears/c_languages: Add OClintBear #2149

Are you sure you want to change the base?

bears/c_languages: Add OClintBear #2149

Conversation

bhavishyagopesh commented Dec 4, 2017 • edited

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

newbazz left a comment

Choose a reason for hiding this comment

bhavishyagopesh commented Dec 4, 2017 • edited

khanchi97 left a comment

Choose a reason for hiding this comment

bhavishyagopesh commented Dec 5, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

newbazz left a comment

Choose a reason for hiding this comment

bhavishyagopesh commented Dec 4, 2017 •

edited

bhavishyagopesh commented Dec 4, 2017 •

edited