LineContinuationBear: Add ignore_with option
#2844
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But check why AppVeyor build is failing |
|
It was because there wasn't 100% test coverage. Now I have added the necessary tests. |
|
Now it appears good, @li-boxuan please review this. |
kiy4h
approved these changes
Jan 25, 2019
|
@gitmate-bot rebase |
|
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
Add `ignore_with` option in LineContinuationBear to ignore backslashes used in `with` statements. Closes coala#2807
|
Automated rebase with GitMate.io was successful! 🎉 |
jayvdb
requested changes
Feb 4, 2019
| file='default')], | ||
| filename='default') | ||
| self.check_validity( | ||
| self.uut, ["with open('hey.txt') as \\", |
There was a problem hiding this comment.
this is invalid syntax. Please use valid syntax in the python you use for your test cases
jayvdb
reviewed
Feb 4, 2019
| ) | ||
| ) | ||
| elif len(line) > 1 and ignore_with: | ||
| if line[-2] in line_continuation and line[:5] != 'with ': |
There was a problem hiding this comment.
line[:5] assumes the position of with in the source line, which is not acceptable as with can appear at any indentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ignore_withoption in LineContinuationBear to ignorebackslashes used in
withstatements.Closes #2807
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
corobo mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!