Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] CROSSTEST #314

Closed
wants to merge 3 commits into from
Closed

[WIP] CROSSTEST #314

wants to merge 3 commits into from

Conversation

Makman2
Copy link
Member

@Makman2 Makman2 commented Apr 1, 2016

This is for coala/coala#1992

It tests whether the Shell commits work fine as they broke coala-bears a while back

@@ -45,6 +45,13 @@ go get -u golang.org/x/tools/cmd/gotype
# Ruby commands
bundle install

pip install appdirs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to do it after the for loop.
As the for loop runs pyenv local $dep_version 2.7.10 which sets the python version to use for this circleci container

@@ -39,6 +39,13 @@ install:
- "python --version"
- "python -c \"import struct; print(struct.calcsize('P') * 8)\""

- "%CMD_IN_ENV% pip install appdirs"
- git clone https://github.com/coala-analyzer/coala coala-manuall-branch-inst
- cd coala-manuall-branch-inst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to add coala-manuall-branch-inst tot he ignored folders of pytest
The tests in this folder will get run too

@AbdealiLoKo
Copy link
Contributor

@Makman2 I've forced push to your branch.
I added the coala folder to be ignored by pytest. I think something was failing and changing the directory or something ... Not sure what was happening.

For commit 9d30f31
CircleCI seems to work - link to build 951 although your Shell commits dont work : P
Appveyor seems to work and pass ! - link to build 1.0.784
Not sure why travis continues to fail at setup.py ... link to build 120297641

@sils
Copy link
Member

sils commented Apr 13, 2016

@Makman2 is this branch still needed?

@Makman2
Copy link
Member Author

Makman2 commented Apr 13, 2016

yes please keep it

@Makman2
Copy link
Member Author

Makman2 commented Apr 25, 2016

closing this PR, but please don't remove the branch, crosstesting is generally useful sometimes^^

@Makman2 Makman2 closed this Apr 25, 2016
@AbdealiLoKo
Copy link
Contributor

It;s better if you delete the branch but document it in the docs don't you
think ?

On Tue, Apr 26, 2016 at 1:19 AM, Mischa Krüger notifications@github.com
wrote:

Closed #314 #314.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#314 (comment)

@AbdealiLoKo
Copy link
Contributor

Created coala/coala#2074

On Tue, Apr 26, 2016 at 7:20 AM, Abdeali Kothari abdealikothari@gmail.com
wrote:

It;s better if you delete the branch but document it in the docs don't you
think ?

On Tue, Apr 26, 2016 at 1:19 AM, Mischa Krüger notifications@github.com
wrote:

Closed #314 #314.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#314 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants