Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coala html binary #31

Closed
3 tasks done
tushar-rishav opened this issue Feb 28, 2016 · 5 comments
Closed
3 tasks done

coala html binary #31

tushar-rishav opened this issue Feb 28, 2016 · 5 comments

Comments

@tushar-rishav
Copy link
Member

tushar-rishav commented Feb 28, 2016

From @AbdealiJK on February 28, 2016 5:57

So, as I see it the coala html binary needs to do three things:

Install coala-html angular app via bower. Also install the bower dependencies.

  • run coala and dump the results in json format to a particular file if it doesn't exists else update it. This file shall be used by Angular app.
  • create file.json if it doesn't exists else update it.
  • Finally, create a server and open the file. This can have some flexibility. User can decide whether to launch the webpage immediately after running coala-html or maybe just update/create the files.

Fixes #31

We probably want an arg to just create the server / open the last result too.

Copied from original issue: coala/coala#1733

@tushar-rishav
Copy link
Member Author

@AbdealiJK

  • We might want to add an option that allows users to switch between the output from predefined location or run coala-json and update the output.
  • Yes we should create a file.json the first time we run coala-json.
  • Webbrowser is what we might need.

@AbdealiLoKo
Copy link
Contributor

@tushar-rishav I agree with everything you mentioned in the comment.
And Im wondering why this was moved to coala-html repo. I thought the python coala-html binary can reside in coala and only the bower package can reside in coala-html. coala uses the bower package coala-html and renders the html thing

@AbdealiLoKo
Copy link
Contributor

I dind't want to add python setup.py and stuff here

@tushar-rishav
Copy link
Member Author

@AbdealiJK Sorry got confused. I thought we should move all coala-html related talks to this repo. Anyway feel free to switch back. :P

@AbdealiLoKo
Copy link
Contributor

@tushar-rishav just a note as you asked on gitter once about package-data

https://github.com/django/django-localflavor/blob/master/setup.py#L37
has a nice function which seems to be cool.
Its MIT so you can copy and give appropriate credit (as they've done at the top of the function)

tushar-rishav added a commit that referenced this issue Mar 16, 2016
This commit wraps angular package with coala-html
Python package. It also adds an option to launch webpage
by running binary. User has an option to:
1. Launch a webpage from existing results
2. Update the results json and not launch a webpage.
3. Option to provide path to store the generated webpages

Fixes #31
tushar-rishav added a commit that referenced this issue Mar 16, 2016
This commit wraps angular package with coala-html
Python package. It also adds an option to launch webpage
by running binary. User has an option to:
1. Launch a webpage from existing results
2. Update the results json and not launch a webpage.
3. Option to provide path to store the generated webpages

Fixes #31
tushar-rishav added a commit that referenced this issue Mar 18, 2016
This commit wraps angular package with coala-html
Python package. It also adds an option to launch webpage
by running binary. User has an option to:
1. Launch a webpage from existing results
2. Update the results json and not launch a webpage.
3. Option to provide path to store the generated webpages

Fixes #31
tushar-rishav added a commit that referenced this issue May 6, 2016
This commit wraps angular package with coala-html
Python package. It also adds an option to launch webpage
by running binary. User has an option to:
1. Launch a webpage from existing results
2. Update the results json and not launch a webpage.
3. Option to provide path to store the generated webpages

Fixes #31
tushar-rishav added a commit that referenced this issue May 10, 2016
This commit wraps angular package with coala-html
Python package. It also adds an option to launch webpage
by running binary. User has an option to:
1. Launch a webpage from existing results
2. Update the results json and not launch a webpage.
3. Option to provide path to store the generated webpages
The current branch has been updated with current master
with unittests.

Fixes #31
tushar-rishav added a commit that referenced this issue May 15, 2016
This commit wraps the angular app within a standalone
Python package. Functionalities implemented with present
version are:
1. Create necessary `data` files like files.json, coala.json
   etc. and launch the server.
2. User can run coala and has an option to either launch the
   server or just update the data files.
3. Static dependencies are being fetched from bower. If
   bower isn't installed then user gets a info to install bower
   first and then try again.
4. `files.json` has been implemented using data obtained from
   `file_dict` which coala returns post analysis.

Fixes #31,
#43
tushar-rishav added a commit that referenced this issue May 15, 2016
This commit wraps the angular app within a standalone
Python package. Functionalities implemented with present
version are:
1. Create necessary `data` files like files.json, coala.json
   etc. and launch the server.
2. User can run coala and has an option to either launch the
   server or just update the data files.
3. Static dependencies are being fetched from bower. If
   bower isn't installed then user gets a info to install bower
   first and then try again.
4. `files.json` has been implemented using data obtained from
   `file_dict` which coala returns post analysis.

Fixes #31,
#43
tushar-rishav added a commit that referenced this issue May 15, 2016
This commit wraps the angular app within a standalone
Python package. Functionalities implemented with present
version are:
1. Create necessary `data` files like files.json, coala.json
   etc. and launch the server.
2. User can run coala and has an option to either launch the
   server or just update the data files.
3. Static dependencies are being fetched from bower. If
   bower isn't installed then user gets a info to install bower
   first and then try again.
4. `files.json` has been implemented using data obtained from
   `file_dict` which coala returns post analysis.

Fixes #31
Fixes #43
tushar-rishav added a commit that referenced this issue May 15, 2016
This commit wraps the angular app within a standalone
Python package. Functionalities implemented with present
version are:
1. Create necessary `data` files like files.json, coala.json
   etc. and launch the server.
2. User can run coala and has an option to either launch the
   server or just update the data files.
3. Static dependencies are being fetched from bower. If
   bower isn't installed then user gets a info to install bower
   first and then try again.
4. `files.json` has been implemented using data obtained from
   `file_dict` which coala returns post analysis.

Fixes #31
Fixes #43
tushar-rishav added a commit that referenced this issue May 16, 2016
This commit wraps the angular app within a standalone
Python package. Functionalities implemented with present
version are:
1. Create necessary `data` files like files.json, coala.json
   etc. and launch the server.
2. User can run coala and has an option to either launch the
   server or just update the data files.
3. Static dependencies are being fetched from bower. If
   bower isn't installed then user gets a info to install bower
   first and then try again.
4. `files.json` has been implemented using data obtained from
   `file_dict` which coala returns post analysis.

Fixes #31
Fixes #43
tushar-rishav added a commit that referenced this issue May 16, 2016
This commit wraps the angular app within a standalone
Python package. Functionalities implemented with present
version are:
1. Create necessary `data` files like files.json, coala.json
   etc. and launch the server.
2. User can run coala and has an option to either launch the
   server or just update the data files.
3. Static dependencies are being fetched from bower. If
   bower isn't installed then user gets a info to install bower
   first and then try again.
4. `files.json` has been implemented using data obtained from
   `file_dict` which coala returns post analysis.

Fixes #31
Fixes #43
tushar-rishav added a commit that referenced this issue May 16, 2016
This commit wraps the angular app within a standalone
Python package. Functionalities implemented with present
version are:
1. Create necessary `data` files like files.json, coala.json
   etc. and launch the server.
2. User can run coala and has an option to either launch the
   server or just update the data files.
3. Static dependencies are being fetched from bower. If
   bower isn't installed then user gets a info to install bower
   first and then try again.
4. `files.json` has been implemented using data obtained from
   `file_dict` which coala returns post analysis.

Fixes #31
Fixes #43
tushar-rishav added a commit that referenced this issue May 26, 2016
tushar-rishav added a commit that referenced this issue May 26, 2016
tushar-rishav added a commit that referenced this issue May 26, 2016
tushar-rishav added a commit that referenced this issue May 26, 2016
tushar-rishav added a commit that referenced this issue May 26, 2016
tushar-rishav added a commit that referenced this issue May 27, 2016
tushar-rishav added a commit that referenced this issue May 27, 2016
colorama needs to be upgraded to fix error when installed
colorama version and required are different.

Refs #31
tushar-rishav added a commit that referenced this issue May 27, 2016
tushar-rishav added a commit that referenced this issue May 27, 2016
tushar-rishav added a commit that referenced this issue May 27, 2016
This commit:
1.Replaces `tests/test_projects/*` with
`data` directory.
2.files.js: Create file hierarchy using `data/` files

Refs #31
tushar-rishav added a commit that referenced this issue May 27, 2016
tushar-rishav added a commit that referenced this issue May 27, 2016
tushar-rishav added a commit that referenced this issue May 27, 2016
tushar-rishav added a commit that referenced this issue May 27, 2016
This commit:
1.Replaces `tests/test_projects/*` with
`data` directory.
2.files.js: Create file hierarchy using `data/` files

Refs #31
tushar-rishav added a commit that referenced this issue May 27, 2016
tushar-rishav added a commit that referenced this issue May 27, 2016
tushar-rishav added a commit that referenced this issue May 27, 2016
tushar-rishav added a commit that referenced this issue May 27, 2016
This commit:
1.Replaces `tests/test_projects/*` with
`data` directory.
2.Create file hierarchy using `data/` files

Refs #31
tushar-rishav added a commit that referenced this issue May 27, 2016
tushar-rishav added a commit that referenced this issue May 27, 2016
tushar-rishav added a commit that referenced this issue May 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants