Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed python 3.3 dependency #58

Merged
merged 1 commit into from
Dec 14, 2016
Merged

Removed python 3.3 dependency #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .ci/deps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ set -x

# Choose the python versions to install deps for
case $CIRCLE_NODE_INDEX in
*) dep_versions=( "3.3.6" ) ;;
1) dep_versions=( "3.4.3" ) ;;
2) dep_versions=( "3.5.1" ) ;;
*) dep_versions=( "3.4.3" ) ;;
1) dep_versions=( "3.5.1" ) ;;
esac

for dep_version in "${dep_versions[@]}" ; do
Expand All @@ -16,4 +15,4 @@ for dep_version in "${dep_versions[@]}" ; do

pip3 install -q -r test-requirements.txt
pip3 install -q -r requirements.txt
done
done
Copy link
Member

@Mixih Mixih Dec 13, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the newline here(at EOF) intentional?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never; it is always bad on unix, except in a test file to show how bad it is.

Copy link
Contributor Author

@paniabhisek paniabhisek Dec 14, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emacs always adds a newline at the end of the file and always clears up trailing whitespaces. Is adding a newline at the end of the file is bad ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emacs is doing the right thing, assuming you are the author of that file.

It is distracting to add an EOL at EOF in a patch which isnt about that.
So, check your diff before you PR, and undo this emacs fixup unless you are modifying the last line of the file.

Ideally we create a bear to require it (coala/coala-bears#815), and then fix all the EOL problems at once. Until then, ignore any missing EOLs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhisek- Or you could add another commit fixing just that (although I'm leaning towards a end-of-line bear too). The idea is that each commit should be about one thing and just that one thing. Makes it much easier later on when you go through your commits.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, this is merged lol

Guess we'll go with the bear thing now :D

Copy link
Contributor Author

@paniabhisek paniabhisek Dec 20, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah..that was a mistake. I'll keep that in mind.