Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed python 3.3 dependency #58

Merged
merged 1 commit into from
Dec 14, 2016

Conversation

paniabhisek
Copy link
Contributor

Changed the file .ci/deps.sh so that it doesn't support python3.3
anymore as python3.3 hasn't been supported by coala for a long time.
see #35

Closes #57

@gitmate-bot
Copy link

Thanks for your contribution!

Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.

As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!

@gitmate-bot
Copy link

Comment on 8550e48.

Shortlog of HEAD commit isn't in imperative mood! Bad words are 'Removed'

GitCommitBear, severity NORMAL, section commit.

Changed the file .ci/deps.sh so that it doesn't support python3.3
anymore as python3.3 hasn't been supported by coala for a long time.
see coala#35

Closes coala#57
done
Copy link
Member

@Mixih Mixih Dec 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the newline here(at EOF) intentional?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never; it is always bad on unix, except in a test file to show how bad it is.

Copy link
Contributor Author

@paniabhisek paniabhisek Dec 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emacs always adds a newline at the end of the file and always clears up trailing whitespaces. Is adding a newline at the end of the file is bad ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emacs is doing the right thing, assuming you are the author of that file.

It is distracting to add an EOL at EOF in a patch which isnt about that.
So, check your diff before you PR, and undo this emacs fixup unless you are modifying the last line of the file.

Ideally we create a bear to require it (coala/coala-bears#815), and then fix all the EOL problems at once. Until then, ignore any missing EOLs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhisek- Or you could add another commit fixing just that (although I'm leaning towards a end-of-line bear too). The idea is that each commit should be about one thing and just that one thing. Makes it much easier later on when you go through your commits.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, this is merged lol

Guess we'll go with the bear thing now :D

Copy link
Contributor Author

@paniabhisek paniabhisek Dec 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah..that was a mistake. I'll keep that in mind.

@jayvdb
Copy link
Member

jayvdb commented Dec 14, 2016

ack 18a79df

@jayvdb
Copy link
Member

jayvdb commented Dec 14, 2016

@rultor merge

@rultor
Copy link

rultor commented Dec 14, 2016

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 18a79df into coala:master Dec 14, 2016
@rultor
Copy link

rultor commented Dec 14, 2016

@rultor merge

@jayvdb Done! FYI, the full log is here (took me 1min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

6 participants