Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest usage of git push --force-with-lease instead of git push -f in rebasing tutorials #2250

Closed
underyx opened this issue Jun 3, 2016 · 9 comments

Comments

@underyx
Copy link
Member

underyx commented Jun 3, 2016

area/documentation

@gitmate-bot
Copy link
Collaborator

Thanks for reporting this issue!

Your aid is required, fellow coalaian. Help us triage and solving this issue!

CC @sils1297, @AbdealiJK

@sils
Copy link
Member

sils commented Jun 3, 2016

I'm not fully sure about that because you have to explain more to new people.

@Makman2
Copy link
Member

Makman2 commented Jun 4, 2016

I'm against this as I agree with @sils1297 , the command looks like it needs more explanation because of the "remote-tip-need-to-be-equal" protection, with our review system there is in principle no possibility to merge such malicious branches (master is protected by GitHub, notification in PR that branch is out-of-date, rultor refuses merge). Our workflow is also more like "that is definitely your branch" and no-one would touch it (unless there are special exceptions if someone wants to take over directly etc, though in fact there's no need for such arrangements).

@underyx
Copy link
Member Author

underyx commented Jun 4, 2016

Can't really refute all that, but just to reply to this one point:

Our workflow is also more like "that is definitely your branch"

I've deleted my own commit before with a force push when I forgot I had already changed something with the github.com editor :D

@Makman2
Copy link
Member

Makman2 commented Jun 4, 2016

don't do so :3

@sils
Copy link
Member

sils commented Jun 17, 2016

so what do we do? I'm currently leaning towards the simpler solution. Might also be because I'm lazy and I'm in issue closing mood though :P

@Makman2
Copy link
Member

Makman2 commented Jun 17, 2016

maybe we can mention inside a note "if you want more protective behaviour, you can also use --force-with-lease" or so^^

@sils
Copy link
Member

sils commented Jun 17, 2016

I like adding a note!
On 17 Jun 2016 6:26 p.m., "Mischa Krüger" notifications@github.com wrote:

maybe we can mention inside a note "if you want more protective behaviour,
you can also use --force-with-lease" or so^^


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2250 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AFc6KN7rdeoV9JU25C4RonAw-9aFcgmOks5qMsrFgaJpZM4It10Q
.

@Adrianzatreanu
Copy link
Contributor

This issue was moved to coala/documentation#38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants