Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vi is not added to the list of editors #5239

Open
karansingh1559 opened this issue Mar 4, 2018 · 11 comments · Fixed by karansingh1559/coala#1 · May be fixed by #5280
Open

Vi is not added to the list of editors #5239

karansingh1559 opened this issue Mar 4, 2018 · 11 comments · Fixed by karansingh1559/coala#1 · May be fixed by #5280

Comments

@karansingh1559
Copy link

Coala does not recognise vi as an editor, although it does recognise vim and nvim.
Vi needs to be added to the list of editors in OpenEditorAction.py
This is what happens when you try to open a file with vi:

Please enter a value for the parameter 'editor' (The editor to open the file with.): vi

choose vi editor

The editor "vi" is unknown to coala. Files won't be opened at the correct positions and other quirks might occur. Consider opening an issue at https://github.com/coala/coala/issues so we can add support for this editor. Supported editors are: atom, emacs, emacsclient, geany, gedit, gvim, kate, nano, nvim, subl, vim, xed

@karansingh1559
Copy link
Author

@Makman2 If this is a valid issue, please assign this to me :D

@RaiVaibhav
Copy link
Member

RaiVaibhav commented Mar 5, 2018

Add Atom also in gui editors

@karansingh1559
Copy link
Author

@RaiVaibhav atom is already there :)

@aramadsanar
Copy link

Hi @karansingh1559, can you assign this to me? I would like to work on this issue :)

Thanks

@jayvdb
Copy link
Member

jayvdb commented Mar 9, 2018

why cant you use vim ?

vi is a different editor.

@Naveenaidu
Copy link
Member

@aramadsanar Only maintainers can assign issues. Please ask @Makman2 to assign the issue to you. :')

@sangamcse
Copy link
Member

@jayvdb, I feel that vi should also be an option.

vi is a different editor.

@Makman2
Copy link
Member

Makman2 commented Mar 11, 2018

I feel that too 👍 Because they are ("slightly") different editors, coala should offer it as an option.

@jayvdb
Copy link
Member

jayvdb commented Apr 7, 2018

vi is ex. Nobody uses that anymore.
I can appreciate the need for other vi clones, but they are not vi.

@karansingh1559, which vi do you have? Is it a package on your system, or you compiled it from source? Which source?

http://ex-vi.sourceforge.net/ is unmaintained, and doesnt even compile these days with GNU C library.

But there are other branches of the vi family, so maybe another one is still alive with die hard fans ... fans who surely think ex is too old skool for them ;-)

@sangamcse
Copy link
Member

vi --version
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Nov 29 2017 18:37:46)
Included patches: 1-503, 505-680, 682-1283
Compiled by root@apple.com
Normal version without GUI.

In my system, it is a package which was updated recently with MacOS 10.13.2 Developer Beta update.

@jayvdb
Copy link
Member

jayvdb commented Apr 8, 2018

right. That is vim, not vi. You also have a executable called vim I assume. Most systems now alias vi to vim, or have a vi which is a slightly cut down version of vim. Someone using vim should specify they are using vim as their editor.

If we want to help people who are using vim masquerading as vi, and dont know what to call it, we could have a feature which informs them to use vim. That is different from creating support for a vi editor which is not conforming to the relevant spec for vi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment