OpenEditorAction.py: added vi to list of editors #5280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vi has been added to the list of non-gui editors Fixes coala#5239
OpenEditorAction.py: Added vi to list of editors
|
Comment on 470bd79. Shortlog of the HEAD commit contains 63 character(s). This is 13 character(s) longer than the limit (63 > 50). Origin: GitCommitBear, Section: |
|
Comment on ef59740. Shortlog of HEAD commit isn't in imperative mood! Bad words are 'Added' Origin: GitCommitBear, Section: |
aabhaas-vaish
suggested changes
Mar 21, 2018
There was a problem hiding this comment.
Please squash your commits into one.
In the final commit message's shortlog use 'add' instead of 'added' and ensure that the shortlog is less than 50 characters.
Also, since this is not exactly a bug, the reference issue line (last line) should include 'closes' instead of 'fixes'.
yashovardhan
suggested changes
Mar 22, 2018
jayvdb
requested changes
Apr 7, 2018
| @@ -44,6 +44,10 @@ | |||
| 'file_arg_template': '{filename} +{line}', | |||
| 'gui': False | |||
| }, | |||
| 'vi': { | |||
| 'file_arg_template': '{filename} +{line}', | |||
There was a problem hiding this comment.
I am pretty confident that the +{line} support was added in vim, not vi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vi has been added to the list
of non-gui editors
Fixes #5239
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
cobot mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!