Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+Z command to terminate the program not working in Windows #5254

Open
Makman2 opened this issue Mar 11, 2018 · 9 comments · May be fixed by #5979
Open

Ctrl+Z command to terminate the program not working in Windows #5254

Makman2 opened this issue Mar 11, 2018 · 9 comments · May be fixed by #5979

Comments

@Makman2
Copy link
Member

Makman2 commented Mar 11, 2018

image

coala must terminate after pressing Ctrl+Z keys as shown in the CLI.

Migrated from coala/coala-bears#1612

@gitmate-bot
Copy link
Collaborator

GitMate.io thinks possibly related issues are #292 (globs don't work on windows), #2328 (cat doesn't work in Windows), #3322 (PycodestyleBear doesn't work on Windows), #3410 (Don't show "Ctrl+D to exit" on windows), and #242 (ctrl+C does not quit the program).

@guilherme-p
Copy link
Contributor

Can I get this one @Makman2?

@jayvdb
Copy link
Member

jayvdb commented Mar 12, 2018

Please finish coala/coalaCSS#31 first, then you can take this one.

@guilherme-p
Copy link
Contributor

Done @jayvdb @Makman2

@arnav-mandal1234
Copy link

@jayvdb @Makman2 Can I work on this issue?
This is inactive for a long time.

@arnav-mandal1234
Copy link

@jayvdb @Makman2 I searched about this matter but In windows, Ctrl + Z +Enter, terminates the program whereas if we use Ctrl + C, it closes the program abruptly. So, I think we should change it to Ctrl + Z + Enter, to maintain the organized working of Coala.

@jayvdb
Copy link
Member

jayvdb commented Feb 4, 2019

@arnav-mandal1234 , that was what @guilherme-p did in their PR. It is a sensible approach to fix the bug.

@arnav-mandal1234
Copy link

@jayvdb should I submit a PR with the following changes?

@KVGarg
Copy link
Contributor

KVGarg commented Feb 5, 2019

@arnav-mandal1234 you can create a PR for this, since the previous PR was closed due to non-availability of permissions to make changes. I think, it will be make sense to create a new PR for it.

arnav-mandal1234 added a commit to arnav-mandal1234/coala that referenced this issue Feb 7, 2019
@arnav-mandal1234 arnav-mandal1234 linked a pull request Feb 7, 2019 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment