coala_main.py: Changed Ctrl-Z to Ctrl-Z-Enter #5362
Conversation
|
Comment on 92beba6. Shortlog of HEAD commit isn't in imperative mood! Bad words are 'Changed' Origin: GitCommitBear, Section: |
|
not for the future, no maintainer will merge a pr filed from master branch |
coalib/coala_main.py
Outdated
| @@ -29,7 +29,7 @@ def do_nothing(*args): | |||
|
|
|||
|
|
|||
| STR_ENTER_NUMBER = 'Enter number (Ctrl-{} to exit): '.format( | |||
| 'Z' if platform.system() == 'Windows' else 'D') | |||
| 'Z-Enter' if platform.system() == 'Windows' else 'D') | |||
There was a problem hiding this comment.
@guilherme-p @yzgyyang is there no way to exit the program in a single combination key stroke?
There was a problem hiding this comment.
Since we need to press enter after Ctrl-Z to terminate the program, the message shouldn’t be ‘Ctrl-Z-Enter’ since it may confuse people to press the three keys as a combination. Also, I think we could consider use Ctrl-C in this case, although it doesn’t send an EOF to terminate the program, coala should behave the same in both cases.
There was a problem hiding this comment.
Can you please leave a note on the issue explaining how you think we should solve the problem?
|
Inactive PR. |
|
Last commit in PR was 92beba6 ; I tried to rebase and didnt have permission. |
Closes #5254
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
corobo mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!