ConsoleInteractionTest.py: test_ask_for_actions_and_apply defined twice

[akshatkarani]

Change the name of one of the function to something more appropriate.
difficulty/newcomer

[charfole]

Will there be difficulty/newcomer labels with this issue？
I‘m a newcomer so that I look for the issues with this label to practice.

[akshatkarani]

Most probably, but you should only work on this issue after getting assigned. Please read our Newcomers Guidelines and Commit Guidelines

[charfole]

Copy that,THANKS!

[jayvdb]

@charfole , sorry for the delay - assigned now

[charfole]

@jayvdb ，It's OK. Thanks for your assigning.

[sameshl]

As there has not been any activity on this issue for more that 15 days, Can someone assign me this. I would love to work on it.

[RJ722]

seems like @charfole isn't working on this. assigning @sameshl

[sameshl]

@RJ722 I looked at

coala/tests/output/ConsoleInteractionTest.py

Lines 552 to 588 in bcee2cd

	def test_ask_for_actions_and_apply(self):
	failed_actions = set()
	action = TestAction()
	do_nothing_action = DoNothingAction()
	args = [self.console_printer, Section(''),
	[do_nothing_action.get_metadata(), action.get_metadata()],
	{id(do_nothing_action): do_nothing_action, id(action): action},
	failed_actions, Result('origin', 'message'), {}, {}, {}]
	with simulate_console_inputs('a', 'param1', 'a', 'param2') as generator:
	action.apply = unittest.mock.Mock(side_effect=AssertionError)
	ask_for_action_and_apply(*args)
	self.assertEqual(generator.last_input, 1)
	self.assertIn('TestAction', failed_actions)
	action.apply = lambda *args, **kwargs: {}
	ask_for_action_and_apply(*args)
	self.assertEqual(generator.last_input, 3)
	self.assertNotIn('TestAction', failed_actions)
	def test_ask_for_actions_and_apply(self):
	failed_actions = set()
	action = TestAction()
	args = [self.console_printer, Section(''),
	[action.get_metadata()], {id(action): action},
	failed_actions, Result('origin', 'message'), {}, {}, {}]
	with simulate_console_inputs('a', 'param1', 'a', 'param2') as generator:
	action.apply = unittest.mock.Mock(side_effect=AssertionError)
	ask_for_action_and_apply(*args)
	self.assertEqual(generator.last_input, 1)
	self.assertIn('TestAction', failed_actions)
	action.apply = lambda *args, **kwargs: {}
	ask_for_action_and_apply(*args)
	self.assertEqual(generator.last_input, 3)
	self.assertNotIn('TestAction', failed_actions)

but was not able to figure out a better way to rename them. Could you please help me out?

Thanks!

[RJ722]

It seems like the both the functions are mostly identical and that the first function is also additionally testing with DoNothingAction. This leads to a lot of code being duplicated - we would ideally want only one test in which both of these conditions could be tested.

One idea off the top of my head to do so would be to have a list of args and run the with statement within a loop for every arg in args, but it might take a little poking around to do so.

I'm turning this into a difficulty/low issue. @sameshl you can continue working on this issue and if you face any difficulties, please let us know and we'd be happy to help. :-)

[MaskedCarrot]

As there has not been any activity on this issue for about a month now can I work on it?

[Purvanshsingh]

I am a newcomer can you please assign me this issue?

[tyajush]

Hi I would like to contribute to this issue, can someone please assign me. I am just getting started with open source contributions.

[sky3760000]

if the work is not completed, can u please assign me this issue?