No need of --files flag with only global bears #4997

ishanSrt · 2017-12-21T22:47:06Z

Explanation:
Lines 506-515: Check if only global bears are present and pass around variable only_global_bears
Lines 191-193: Check if only global bears are present and and only the files param is missing. Don't System Exit in that case
Lines 215-219: In the above mentioned case don't print out warning message

So if --files is not provided and only global bears are used, coala operates on nothing

pradeepgangwar

You commit message needs modification:
Please read this guide and try to modify commit message. :)

ishanSrt · 2017-12-22T17:08:27Z

@pradeepgangwar be more precise.

pradeepgangwar · 2017-12-22T17:15:40Z

quoting it from the link i mentioned in previous comment.

A commit message consists of 3 parts:

shortlog

commit body

issue reference

your commit message should follow this style.

ishanSrt · 2017-12-22T17:17:14Z

@pradeepgangwar commit body is optional only to describe the things that are not self explanatory. Read that entire doc, carefully.

pradeepgangwar · 2017-12-22T17:44:19Z

coalib/settings/ConfigurationGathering.py

    save_sections(sections)
-    warn_nonexistent_targets(targets, sections)
+    warn_nonexistent_targets(targets, sections, only_global_bears)


I think you should add global_bears parameter to gather_configuration function too, where it calls warn_nonexistent_targets and then see build log, they fail because of this.

what is meant by global bears option?

the checks are failing because of the test cases. all bears till now have to have a --files tag. now I am changing that so the tests yell at me why didn't coala quit when the --files was not specified

gitmate-bot · 2018-01-01T04:26:28Z

Comment on e080761, file coalib/settings/ConfigurationGathering.py, line 173.

Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpfrcy4o9m/coalib/settings/ConfigurationGathering.py
+++ b/tmp/tmpfrcy4o9m/coalib/settings/ConfigurationGathering.py
@@ -170,7 +170,7 @@
     :param targets:           The targets to check.
     :param sections:          The sections to search. (Dict.)
     :param log_printer:       The log printer to warn to.
-    :param only_global_bears: True if only global bears are 
+    :param only_global_bears: True if only global bears are
                               are being run
     """
     for target in targets:

gitmate-bot · 2018-01-01T04:26:28Z

Comment on e080761, file coalib/settings/ConfigurationGathering.py, line 190.

Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpfrcy4o9m/coalib/settings/ConfigurationGathering.py
+++ b/tmp/tmpfrcy4o9m/coalib/settings/ConfigurationGathering.py
@@ -187,7 +187,7 @@
     bears_config_absent, arg_bears = warn_config_absent(sections,
                                                         ['bears', 'aspects'],
                                                         only_global_bears)
-    if (files_config_absent or bears_config_absent) and (not (only_global_bears and 
+    if (files_config_absent or bears_config_absent) and (not (only_global_bears and
         files_config_absent and arg_files==['files'])) :
         raise SystemExit(2)  # Invalid CLI options provided

gitmate-bot · 2018-01-01T04:26:30Z

Comment on e080761, file coalib/settings/ConfigurationGathering.py, line 165.

Line is longer than allowed. (85 > 80)

Origin: LineLengthBear, Section: linelength.

gitmate-bot · 2018-01-01T04:26:31Z

Comment on e080761, file coalib/settings/ConfigurationGathering.py, line 190.

Line is longer than allowed. (84 > 80)

Origin: LineLengthBear, Section: linelength.

gitmate-bot · 2018-01-01T04:26:31Z

Comment on e080761.

Shortlog of the HEAD commit contains 66 character(s). This is 16 character(s) longer than the limit (66 > 50).

Origin: GitCommitBear, Section: commit.

gitmate-bot · 2018-01-01T04:31:04Z

coalib/settings/ConfigurationGathering.py

@@ -162,14 +162,16 @@ def save_sections(sections):
    conf_writer.close()


-def warn_nonexistent_targets(targets, sections, log_printer=None):
+def warn_nonexistent_targets(targets, sections, only_global_bears, log_printer=None):


Line is longer than allowed. (85 > 80)

Origin: LineLengthBear, Section: linelength.

gitmate-bot · 2018-01-01T04:31:05Z

coalib/settings/ConfigurationGathering.py

+    bears_config_absent, arg_bears = warn_config_absent(sections,
+                                                        ['bears', 'aspects'],
+                                                        only_global_bears)
+    if (files_config_absent or bears_config_absent) and (not (only_global_bears and


Line is longer than allowed. (83 > 80)

Origin: LineLengthBear, Section: linelength.

gitmate-bot · 2018-01-01T04:39:06Z

coalib/settings/ConfigurationGathering.py

+    :param targets:           The targets to check.
+    :param sections:          The sections to search. (Dict.)
+    :param log_printer:       The log printer to warn to.
+    :param only_global_bears: True if only global bears are 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpft6pan2z/coalib/settings/ConfigurationGathering.py +++ b/tmp/tmpft6pan2z/coalib/settings/ConfigurationGathering.py @@ -170,7 +170,7 @@ :param targets: The targets to check. :param sections: The sections to search. (Dict.) :param log_printer: The log printer to warn to. - :param only_global_bears: True if only global bears are + :param only_global_bears: True if only global bears are are being run """ for target in targets:

gitmate-bot · 2018-01-01T04:39:07Z

coalib/settings/ConfigurationGathering.py

+    bears_config_absent, arg_bears = warn_config_absent(sections,
+                                                        ['bears', 'aspects'],
+                                                        only_global_bears)
+    if (files_config_absent or bears_config_absent) and (not (only_global_bears and 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpft6pan2z/coalib/settings/ConfigurationGathering.py +++ b/tmp/tmpft6pan2z/coalib/settings/ConfigurationGathering.py @@ -187,7 +187,7 @@ bears_config_absent, arg_bears = warn_config_absent(sections, ['bears', 'aspects'], only_global_bears) - if (files_config_absent or bears_config_absent) and (not (only_global_bears and + if (files_config_absent or bears_config_absent) and (not (only_global_bears and files_config_absent and arg_files==['files'])) : raise SystemExit(2) # Invalid CLI options provided

gitmate-bot · 2018-01-01T04:39:08Z

coalib/settings/ConfigurationGathering.py

@@ -162,14 +162,16 @@ def save_sections(sections):
    conf_writer.close()


-def warn_nonexistent_targets(targets, sections, log_printer=None):
+def warn_nonexistent_targets(targets, sections, only_global_bears, log_printer=None):


Line is longer than allowed. (85 > 80)

Origin: LineLengthBear, Section: linelength.

gitmate-bot · 2018-01-01T04:39:09Z

coalib/settings/ConfigurationGathering.py

+    bears_config_absent, arg_bears = warn_config_absent(sections,
+                                                        ['bears', 'aspects'],
+                                                        only_global_bears)
+    if (files_config_absent or bears_config_absent) and (not (only_global_bears and 


Line is longer than allowed. (84 > 80)

Origin: LineLengthBear, Section: linelength.

gitmate-bot · 2018-01-01T04:44:15Z

coalib/settings/ConfigurationGathering.py

@@ -162,14 +162,17 @@ def save_sections(sections):
    conf_writer.close()


-def warn_nonexistent_targets(targets, sections, log_printer=None):
+def warn_nonexistent_targets(targets, sections, 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp5wvtkcjo/coalib/settings/ConfigurationGathering.py +++ b/tmp/tmp5wvtkcjo/coalib/settings/ConfigurationGathering.py @@ -162,7 +162,7 @@ conf_writer.close() -def warn_nonexistent_targets(targets, sections, +def warn_nonexistent_targets(targets, sections, only_global_bears, log_printer=None): """ Prints out a warning on the given log printer for all targets that are

gitmate-bot · 2018-01-01T04:44:16Z

coalib/settings/ConfigurationGathering.py

@@ -162,14 +162,17 @@ def save_sections(sections):
    conf_writer.close()


-def warn_nonexistent_targets(targets, sections, log_printer=None):
+def warn_nonexistent_targets(targets, sections, 


The code does not comply to PEP8.

Origin: PEP8Bear, Section: autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp5wvtkcjo/coalib/settings/ConfigurationGathering.py +++ b/tmp/tmp5wvtkcjo/coalib/settings/ConfigurationGathering.py @@ -162,7 +162,7 @@ conf_writer.close() -def warn_nonexistent_targets(targets, sections, +def warn_nonexistent_targets(targets, sections, only_global_bears, log_printer=None): """ Prints out a warning on the given log printer for all targets that are

gitmate-bot · 2018-01-01T04:44:17Z

coalib/settings/ConfigurationGathering.py

@@ -162,14 +162,17 @@ def save_sections(sections):
    conf_writer.close()


-def warn_nonexistent_targets(targets, sections, log_printer=None):
+def warn_nonexistent_targets(targets, sections, 


W291 trailing whitespace

Origin: PycodestyleBear (W291), Section: autopep8.

gitmate-bot · 2018-01-01T04:44:27Z

coalib/settings/ConfigurationGathering.py

+    :param targets:           The targets to check.
+    :param sections:          The sections to search. (Dict.)
+    :param log_printer:       The log printer to warn to.
+    :param only_global_bears: True if only global bears are 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpft6pan2z/coalib/settings/ConfigurationGathering.py +++ b/tmp/tmpft6pan2z/coalib/settings/ConfigurationGathering.py @@ -170,7 +170,7 @@ :param targets: The targets to check. :param sections: The sections to search. (Dict.) :param log_printer: The log printer to warn to. - :param only_global_bears: True if only global bears are + :param only_global_bears: True if only global bears are are being run """ for target in targets:

gitmate-bot · 2018-01-01T04:44:28Z

coalib/settings/ConfigurationGathering.py

+    bears_config_absent, arg_bears = warn_config_absent(sections,
+                                                        ['bears', 'aspects'],
+                                                        only_global_bears)
+    if (files_config_absent or bears_config_absent) and (not (only_global_bears and 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpft6pan2z/coalib/settings/ConfigurationGathering.py +++ b/tmp/tmpft6pan2z/coalib/settings/ConfigurationGathering.py @@ -187,7 +187,7 @@ bears_config_absent, arg_bears = warn_config_absent(sections, ['bears', 'aspects'], only_global_bears) - if (files_config_absent or bears_config_absent) and (not (only_global_bears and + if (files_config_absent or bears_config_absent) and (not (only_global_bears and files_config_absent and arg_files==['files'])) : raise SystemExit(2) # Invalid CLI options provided

jayvdb · 2018-03-17T16:19:37Z

coalib/settings/ConfigurationGathering.py

@@ -162,14 +162,17 @@ def save_sections(sections):
    conf_writer.close()


-def warn_nonexistent_targets(targets, sections, log_printer=None):
+def warn_nonexistent_targets(targets, sections,
+                             only_global_bears, log_printer=None):


never add parameters in the middle of the list; that breaks the API. Add them to the end.

@jayvdb but positional parameters should be before named parameters. Am I missing something over here?

Maybe make it a keyword parameter and shift it to the end?
However, I think we have done deprecation efforts way too long. We are still having 0.x versions, and as a maintainer I would claim our right to break API (as long as we properly mention it in the release notes) especially because we are officially still "alpha" ^^ Those internal things are likely to be not used outside, and people can still use the older version if they are too lazy to update. If we can pin package versions, others can do the same ;)
But @jayvdb that's a different discussion I'm kicking off here, your decision :)

@ishanSrt , it has to be a keyword parameter, or you need to choose a new function name, ideally with a wrapper with the old function name to maintain compatibility.

@Makman2 , One minor release between breakages , otherwise it creates dependency hell which we cant solve without using pre-releases. The real problem is we havent done a minor release in ages.

I will do it but can you explain me in what context are you all talking about? why does this cause API breakage?

jayvdb · 2018-04-06T11:05:15Z

tests/settings/ConfigurationGatheringTest.py

@@ -25,6 +25,7 @@
    gather_configuration,
    get_filtered_bears,
    load_configuration,
+    warn_nonexistent_targets


add trailing comma, so the next person doesnt need to modify your line.

jayvdb · 2018-04-06T11:09:11Z

coalib/settings/ConfigurationGathering.py

-    :param log_printer: The log printer to warn to.
+    :param targets:           The targets to check.
+    :param sections:          The sections to search. (Dict.)
+    :param only_global_bears: True if only global bears are


wrong position in params order

jayvdb · 2018-04-06T11:12:10Z

coalib/settings/ConfigurationGathering.py

@@ -179,7 +182,8 @@ def warn_nonexistent_targets(targets, sections, log_printer=None):

    # Can't be summarized as python will evaluate conditions lazily, those
    # functions have intended side effects though.
-    files_config_absent = warn_config_absent(sections, 'files')
+    files_config_absent = warn_config_absent(


all of the rest of this function is useless if only_global_bears, because that implicitly says there is at least one bear, so bears_config_absent can never be True.

Bail out early if bears_config_absent is True.

i see, all of this function is useless, cause we dont require files and we already know that there is atleast one bear provided by the user if only_global_bears is true

gitmate-bot · 2018-04-07T17:10:51Z

tests/settings/ConfigurationGatheringTest.py

+                log_printer=self.log_printer)
+        except SystemExit:
+            raised = True
+        self.assertFalse(raised)


Line contains following spacing inconsistencies:

No newline at EOF.

Origin: SpaceConsistencyBear, Section: python.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpdwb2__cj/tests/settings/ConfigurationGatheringTest.py +++ b/tmp/tmpdwb2__cj/tests/settings/ConfigurationGatheringTest.py @@ -515,4 +515,4 @@ log_printer=self.log_printer) except SystemExit: raised = True - self.assertFalse(raised)+ self.assertFalse(raised)

gitmate-bot · 2018-04-07T17:10:52Z

tests/settings/ConfigurationGatheringTest.py

+                log_printer=self.log_printer)
+        except SystemExit:
+            raised = True
+        self.assertFalse(raised)


The code does not comply to PEP8.

Origin: PEP8Bear, Section: autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpdwb2__cj/tests/settings/ConfigurationGatheringTest.py +++ b/tmp/tmpdwb2__cj/tests/settings/ConfigurationGatheringTest.py @@ -515,4 +515,4 @@ log_printer=self.log_printer) except SystemExit: raised = True - self.assertFalse(raised)+ self.assertFalse(raised)

gitmate-bot · 2018-04-07T17:10:53Z

tests/settings/ConfigurationGatheringTest.py

+                log_printer=self.log_printer)
+        except SystemExit:
+            raised = True
+        self.assertFalse(raised)


W292 no newline at end of file

Origin: PycodestyleBear (W292), Section: autopep8.

gitmate-bot · 2018-04-07T19:49:11Z

tests/settings/ConfigurationGatheringTest.py

@@ -10,6 +10,7 @@

 from coalib.bearlib.aspects.Metadata import CommitMessage
 from coalib.bearlib.languages import Language
+from coalib.bears.GlobalBear import GlobalBear


This file contains unused source code.

Origin: PyUnusedCodeBear, Section: flakes.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpqy4n7gm2/tests/settings/ConfigurationGatheringTest.py +++ b/tmp/tmpqy4n7gm2/tests/settings/ConfigurationGatheringTest.py @@ -10,7 +10,6 @@ from coalib.bearlib.aspects.Metadata import CommitMessage from coalib.bearlib.languages import Language -from coalib.bears.GlobalBear import GlobalBear from coalib.misc import Constants from coalib.parsing.DefaultArgParser import PathArg from coalib.settings.Section import Section

Fixes coala#4928

jayvdb · 2018-04-08T08:45:54Z

tests/settings/ConfigurationGatheringTest.py

+        sections, local_bears, global_bears, targets = (
+            gather_configuration(
+                *args,
+                arg_list=['-b PyromaBear']))


use a dummy bear, not a real one

jayvdb · 2018-04-08T08:46:41Z

tests/settings/ConfigurationGatheringTest.py

+            gather_configuration(
+                *args,
+                arg_list=['-b PyromaBear']))
+        print(global_bears)


test locally, not as a pull request :P

pradeepgangwar suggested changes Dec 22, 2017

View reviewed changes

pradeepgangwar reviewed Dec 22, 2017

View reviewed changes

gitmate-bot added process/pending review size/XS labels Jan 1, 2018

ishanSrt force-pushed the issue4928final branch from e080761 to a13ff0e Compare January 1, 2018 04:30

gitmate-bot added size/S and removed size/XS labels Jan 1, 2018

gitmate-bot reviewed Jan 1, 2018

View reviewed changes

ishanSrt force-pushed the issue4928final branch from a13ff0e to e7680e6 Compare January 1, 2018 04:38

gitmate-bot added size/XS and removed size/S labels Jan 1, 2018

gitmate-bot reviewed Jan 1, 2018

View reviewed changes

ishanSrt force-pushed the issue4928final branch from 9fb57d2 to 085256c Compare January 1, 2018 04:44

gitmate-bot reviewed Jan 1, 2018

View reviewed changes

jayvdb requested changes Mar 17, 2018

View reviewed changes

jayvdb added process/wip and removed process/pending review labels Mar 17, 2018

ishanSrt force-pushed the issue4928final branch from f651cc3 to e94641c Compare March 29, 2018 17:36

gitmate-bot added process/pending review and removed process/wip labels Mar 29, 2018

ishanSrt force-pushed the issue4928final branch from e94641c to 4f9a4e2 Compare March 29, 2018 18:28

jayvdb requested changes Apr 6, 2018

View reviewed changes

jayvdb added process/wip and removed process/pending review labels Apr 6, 2018

ishanSrt force-pushed the issue4928final branch from 4f9a4e2 to c93dd49 Compare April 7, 2018 17:10

gitmate-bot added process/pending review and removed process/wip labels Apr 7, 2018

gitmate-bot reviewed Apr 7, 2018

View reviewed changes

ishanSrt force-pushed the issue4928final branch 3 times, most recently from 7da74fc to 3226108 Compare April 7, 2018 19:48

gitmate-bot reviewed Apr 7, 2018

View reviewed changes

ishanSrt force-pushed the issue4928final branch 4 times, most recently from 1281fe6 to 7d3ae9a Compare April 7, 2018 20:24

No need of --files flag with only global bears

53af0b1

Fixes coala#4928

ishanSrt force-pushed the issue4928final branch from 7d3ae9a to 53af0b1 Compare April 8, 2018 04:49

jayvdb requested changes Apr 8, 2018

View reviewed changes

jayvdb added process/wip and removed process/pending review labels Apr 8, 2018

No need of --files flag with only global bears #4997

Are you sure you want to change the base?

No need of --files flag with only global bears #4997

Conversation

ishanSrt commented Dec 21, 2017 • edited Loading

So if --files is not provided and only global bears are used, coala operates on nothing

pradeepgangwar left a comment

Choose a reason for hiding this comment

ishanSrt commented Dec 22, 2017

pradeepgangwar commented Dec 22, 2017

ishanSrt commented Dec 22, 2017

pradeepgangwar Dec 22, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ishanSrt Dec 22, 2017 • edited Loading

Choose a reason for hiding this comment

gitmate-bot commented Jan 1, 2018

gitmate-bot commented Jan 1, 2018

gitmate-bot commented Jan 1, 2018

gitmate-bot commented Jan 1, 2018

gitmate-bot commented Jan 1, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ishanSrt Mar 17, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ishanSrt commented Dec 21, 2017 •

edited

Loading

pradeepgangwar Dec 22, 2017 •

edited

Loading

ishanSrt Dec 22, 2017 •

edited

Loading

ishanSrt Mar 17, 2018 •

edited

Loading