Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated requirements.txt #5181

Closed
wants to merge 1 commit into from
Closed

Conversation

amitsin6h
Copy link
Member

@amitsin6h amitsin6h commented Feb 18, 2018

removed redundant version part of setuptools

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@gitmate-bot
Copy link
Collaborator

Comment on 2aae62c.

Shortlog of HEAD commit isn't in imperative mood! Bad words are 'Updated'

Origin: GitCommitBear, Section: commit.

@gitmate-bot
Copy link
Collaborator

Comment on a56becc.

Shortlog of the HEAD commit contains 56 character(s). This is 6 character(s) longer than the limit (56 > 50).

Origin: GitCommitBear, Section: commit.

This remove the redundant version part of setuptools from 21.0.0 to 21
Copy link
Contributor

@monsij monsij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@GabrielDS GabrielDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amitsin6h! How r u?
You broke our first and important rule 😞

DO NOT WORK ON ANY ISSUE WITHOUT ASSIGNMENT!

Please, read more about our Welcome to the Newcomers’ Guide! before make a pull request

@amitsin6h
Copy link
Member Author

amitsin6h commented Feb 18, 2018 via email

@amitsin6h amitsin6h closed this Feb 20, 2018
@amitsin6h amitsin6h deleted the fix-requirements branch February 20, 2018 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants