Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requirements.txt: Remove redundant version part of setuptools #5176

Open
Makman2 opened this issue Feb 17, 2018 · 13 comments
Open

requirements.txt: Remove redundant version part of setuptools #5176

Makman2 opened this issue Feb 17, 2018 · 13 comments
Labels
difficulty/low importance/low status/blocked The issue requires other referenced issues/PRs to be solved/merged before being worked on

Comments

@Makman2
Copy link
Member

Makman2 commented Feb 17, 2018

setuptools>=21.0.0 is equal to setuptools>=21.
@parkerduckworth parkerduckworth mentioned this issue Feb 17, 2018
Closed
@arpit7714
Copy link

can i work on this!

@amitsin6h
Copy link
Member

@Makman2 please review my PR #5181

@monsij
Copy link
Contributor

monsij commented Feb 18, 2018 •
edited

@amitsin6h Get yourself assigned first before you start working on an issue. Please go through http://api.coala.io/en/latest/Developers/Newcomers_Guide.html thoroughly!

@amitsin6h
Copy link
Member

@Makman2 can you assign me.

@Makman2
Copy link
Member Author

Makman2 commented Feb 18, 2018

@arpit7714 was commented first, so I have to assign him. Sorry @amitsin6h

arpit7714 pushed a commit to arpit7714/coala that referenced this issue Feb 18, 2018
reqirements.txt: changed 21.0.0->21
238a04e 
removed the redundant version
of the setuptools from
21.0.0 to 21

Closes coala#5176
arpit7714 pushed a commit to arpit7714/coala that referenced this issue Feb 18, 2018
reqirements.txt: changed 21.0.0->21
2a82c27 
removed the redundant version
of the setuptools from 21.0.0 to 21

Closes coala#5176
arpit7714 pushed a commit to arpit7714/coala that referenced this issue Feb 18, 2018
reqirements.txt: removed redundant version
3d6dc2c 
removed the redundant version
of the setuptools from 21.0.0 to 21

Closes coala#5176
arpit7714 pushed a commit to arpit7714/coala that referenced this issue Feb 18, 2018
reqirements.txt: removed redundant version
4d76f22 
removed the redundant version
of the setuptools from 21.0.0 to 21

Closes coala#5176
arpit7714 pushed a commit to arpit7714/coala that referenced this issue Feb 18, 2018
reqirements.txt: removed redundant version
27a66eb 
removed the redundant version
of the setuptools from 21.0.0 to 21

Closes coala#5176
arpit7714 pushed a commit to arpit7714/coala that referenced this issue Feb 19, 2018
reqirements.txt: corrected redundant version
e60b477 
removed the redundant version
of the setuptools from 21.0.0 to 21

Closes coala#5176
arpit7714 pushed a commit to arpit7714/coala that referenced this issue Feb 19, 2018
reqirements.txt: made changes
c309456 
removed the redundant version
of the setuptools from 21.0.0 to 21

Closes coala#5176
arpit7714 pushed a commit to arpit7714/coala that referenced this issue Feb 19, 2018
reqirements.txt: Removed redundant version
8855e63 
removed the redundant version
of the setuptools from 21.0.0 to 21

Closes coala#5176
arpit7714 pushed a commit to arpit7714/coala that referenced this issue Feb 19, 2018
requirements.txt: Removed redundant version
3bb8e5f 
removed the redundant version
of the setuptools from 21.0.0 to 21

Closes coala#5176
arpit7714 pushed a commit to arpit7714/coala that referenced this issue Feb 19, 2018
reqirements.txt: Chnaged the Version
3af7764 
removed the redundant version
of the setuptools from 21.0.0 to 21

Closes coala#5176
arpit7714 pushed a commit to arpit7714/coala that referenced this issue Feb 19, 2018
reqirements.txt: Changed the Version
79e207a 
removed the redundant version
of the setuptools from 21.0.0 to 21

Closes coala#5176
arpit7714 pushed a commit to arpit7714/coala that referenced this issue Feb 19, 2018
requirements.txt: Changed the Version
4036912 
Removed the redundant version
of the setuptools from 21.0.0 to 21

Closes coala#5176
arpit7714 pushed a commit to arpit7714/coala that referenced this issue Feb 20, 2018
requirements.txt: Changed the Version
69089be 
Removed the redundant version
of the setuptools from 21.0.0 to 21

Closes coala#5176
arpit7714 pushed a commit to arpit7714/coala that referenced this issue Feb 20, 2018
requirements.txt: Changed the Version
83a7660 
Removed the redundant version
of the setuptools from 21.0.0 to 21

Closes coala#5176
arpit7714 pushed a commit to arpit7714/coala that referenced this issue Feb 20, 2018
requirements.txt: Changed the version
ac383ed 
Changed the redundant version
of setuptools from 21.0.0 to 21

Closes coala#5176
arpit7714 pushed a commit to arpit7714/coala that referenced this issue Feb 20, 2018
requirements.txt: Changed now
3db5181 
Changed the redundant version
of setuptools from 21.0.0 to 21

Closes coala#5176
arpit7714 pushed a commit to arpit7714/coala that referenced this issue Feb 20, 2018
requirements.txt: Changed now
558ded7 
Changed the redundant
version of setuptools
 from 21.0.0 to 21

Closes coala#5176
arpit7714 pushed a commit to arpit7714/coala that referenced this issue Feb 21, 2018
requirements.txt: Change version
f22c36b 
Change the redundant
version of setuptools
 from 21.0.0 to 21

Closes coala#5176
arpit7714 pushed a commit to arpit7714/coala that referenced this issue Feb 21, 2018
requirements.txt: Change version
72ac2a6 
Change the redundant version
of setuptools from 21.0.0 to 21

Closes coala#5176
@gitmate-bot
Copy link
Collaborator

This issue seems stale!

@arpit7714 please reassign yourself if you're still working on this.

(Powered by GitMate.io)

@himanshuc3
Copy link

@Makman2 I want to start working on this since no one's assigned!

@himanshuc3 himanshuc3 mentioned this issue Apr 6, 2018
Closed
@jayvdb
Copy link
Member

jayvdb commented Apr 8, 2018

This is a bit more difficult because of .misc/check_setuptools.py

@ananyaarun
Copy link
Member

@jayvdb , @Makman2 can i work on this issue if no one is presently ?

@utkarsh2102
Copy link
Member

@jayvdb, can I take this up?
The one who was working on it seems to be inactive; been 8 months :P

@li-boxuan
Copy link
Member

@himanshuc3 Are you still working on your PR? If not we'll close your PR and assign to others.

@jayvdb
Copy link
Member

jayvdb commented Nov 30, 2018

The low difficulty part of this is check_setuptools.py, and that has now been moved to the mobans repository.

A new issue should be created there to enhance it, or better integrate this check. Until then, this is blocked.

@jayvdb jayvdb added the status/blocked The issue requires other referenced issues/PRs to be solved/merged before being worked on label Nov 30, 2018
@jayvdb
Copy link
Member

jayvdb commented Nov 30, 2018

c.f. #5635 which will lock the sync of these files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/low importance/low status/blocked The issue requires other referenced issues/PRs to be solved/merged before being worked on
Milestone
No milestone
Development

No branches or pull requests
10 participants
@jayvdb @Makman2 @amitsin6h @gitmate-bot @himanshuc3 @arpit7714 @monsij @li-boxuan @utkarsh2102 @ananyaarun