-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requirements.txt: setuptools>=21.0.0 changed to setuptools>=21. #5325
Conversation
Comment on 821b60b. Shortlog of the HEAD commit contains 63 character(s). This is 13 character(s) longer than the limit (63 > 50). Origin: GitCommitBear, Section: |
Comment on 821b60b. Shortlog of HEAD commit contains a period at end. Origin: GitCommitBear, Section: |
Comment on 821b60b. Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*) Origin: GitCommitBear, Section: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#5176 is not a bug, nothing is broken, so Fixes ...
is not appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Closes ...
not closes ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change ur commit message to
change setuptools from 21.0.0 to 21
for a clearer commit message ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be missing something, but you are not removing any versions, just changing it to a better view. So for me commit description looks a bit misleading for now ;)
Comment on c967baa. Shortlog of the HEAD commit contains 53 character(s). This is 3 character(s) longer than the limit (53 > 50). Origin: GitCommitBear, Section: |
Comment on c967baa. Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*) Origin: GitCommitBear, Section: |
Comment on c967baa. Shortlog of the HEAD commit contains 53 character(s). This is 3 character(s) longer than the limit (53 > 50). Origin: GitCommitBear, Section: |
Comment on c967baa. Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*) Origin: GitCommitBear, Section: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first letter after requirements:
must be a capital letter or a digit.
Also you need to use imperative mood in the shortlog.
Read http://coala.io/commit very carefully.
``setuptools>=21.0.0`` was redundant. So, it is changed to ``setuptools>=21`` in this commit. Closes #5176
You'll need to fix |
Abandoned and now sort of redundant. |
setuptools>=21.0.0
was redundant.So, it is changed to
setuptools>=21
in this commit.Closes #5176