Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements.txt: setuptools>=21.0.0 changed to setuptools>=21. #5325

Closed
wants to merge 1 commit into from
Closed

requirements.txt: setuptools>=21.0.0 changed to setuptools>=21. #5325

wants to merge 1 commit into from

Conversation

himanshuc3
Copy link

@himanshuc3 himanshuc3 commented Apr 6, 2018

setuptools>=21.0.0 was redundant.
So, it is changed to setuptools>=21 in this commit.

Closes #5176

@gitmate-bot
Copy link
Collaborator

Comment on 821b60b.

Shortlog of the HEAD commit contains 63 character(s). This is 13 character(s) longer than the limit (63 > 50).

Origin: GitCommitBear, Section: commit.

@gitmate-bot
Copy link
Collaborator

Comment on 821b60b.

Shortlog of HEAD commit contains a period at end.

Origin: GitCommitBear, Section: commit.

@gitmate-bot
Copy link
Collaborator

Comment on 821b60b.

Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*)

Origin: GitCommitBear, Section: commit.

Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5176 is not a bug, nothing is broken, so Fixes ... is not appropriate.

Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Closes ... not closes ...

Copy link
Contributor

@newbazz newbazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change ur commit message to
change setuptools from 21.0.0 to 21
for a clearer commit message ;)

Copy link
Member

@SergeiGorbatiuk SergeiGorbatiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be missing something, but you are not removing any versions, just changing it to a better view. So for me commit description looks a bit misleading for now ;)

@gitmate-bot
Copy link
Collaborator

Comment on c967baa.

Shortlog of the HEAD commit contains 53 character(s). This is 3 character(s) longer than the limit (53 > 50).

Origin: GitCommitBear, Section: commit.

@gitmate-bot
Copy link
Collaborator

Comment on c967baa.

Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*)

Origin: GitCommitBear, Section: commit.

@gitmate-bot
Copy link
Collaborator

Comment on c967baa.

Shortlog of the HEAD commit contains 53 character(s). This is 3 character(s) longer than the limit (53 > 50).

Origin: GitCommitBear, Section: commit.

@gitmate-bot
Copy link
Collaborator

Comment on c967baa.

Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*)

Origin: GitCommitBear, Section: commit.

Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first letter after requirements: must be a capital letter or a digit.

Also you need to use imperative mood in the shortlog.

Read http://coala.io/commit very carefully.

``setuptools>=21.0.0`` was redundant.
So, it is changed to ``setuptools>=21`` in this commit.

Closes #5176
@jayvdb
Copy link
Member

jayvdb commented Apr 8, 2018

You'll need to fix .misc/check_setuptools.py also

@jayvdb
Copy link
Member

jayvdb commented Nov 30, 2018

Abandoned and now sort of redundant.

@jayvdb jayvdb closed this Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants