Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'coala' from COMMIT_AUTHOR_EMAIL #29

Closed
jayvdb opened this issue Dec 7, 2017 · 2 comments
Closed

Remove 'coala' from COMMIT_AUTHOR_EMAIL #29

jayvdb opened this issue Dec 7, 2017 · 2 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented Dec 7, 2017

.travis.yml currently sets COMMIT_AUTHOR_EMAIL: "nobody@coala.io" , but that violates this repositories rule that 'coala' shouldnt be mentioned anywhere.

One approach is to use a generic email address.
Another is to use the git remote info to find the GitHub org (#26), and then derive an email address from the GitHub org.

@andrewda
Copy link
Member

andrewda commented Dec 8, 2017

I think the best we can do here w/o making a GitHub API call is to do something like nobody@{org}.com, but it might not be the best idea to try and guess the org domain if we're going to be wrong 90% of the time. It's probably better to use something like ghost@github.com or {org}@example.com.

@jayvdb jayvdb closed this as completed in b762305 Dec 9, 2017
@nalinbhardwaj
Copy link
Member

nalinbhardwaj commented Dec 10, 2017

@jayvdb this was closed in PR #27 only partially(since the email change was out of scope there). Should I make another PR just changing the email to something generic like CI@travis.com, or something like @andrewda suggested..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants