contributors.html: Show images on contributors page #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitmate-bot
reviewed
Jun 2, 2018
data/contrib_data.py
Outdated
| @@ -27,9 +27,11 @@ def get_contrib_data(): | |||
| def import_data(contributor): | |||
| logger = logging.getLogger(__name__) | |||
| login = contributor.get('login', None) | |||
| image_url = 'https://avatars.githubusercontent.com/' + login | |||
There was a problem hiding this comment.
Broken link - unable to connect to https://avatars.githubusercontent.com/ (HTTP Error: 404)
Origin: InvalidLinkBear, Section: all.links.
gitmate-bot
reviewed
Jun 2, 2018
templates/contributors.html
Outdated
| @@ -17,6 +17,7 @@ <h1>Details of all the contributors</h1> | |||
| <div class="col-sm-6 col-md-4"> | |||
| <div class="thumbnail"> | |||
| <div class="caption"> | |||
| <img src={{contributor.image_url}} alt="user profile"> | |||
There was a problem hiding this comment.
HTML Quotation Marks: Use only double quotes: Change the quotation mark to '"'.
Origin: HTMLLintBear, Section: html.
gitmate-bot
reviewed
Jun 2, 2018
data/contrib_data.py
Outdated
| @@ -27,9 +27,12 @@ def get_contrib_data(): | |||
| def import_data(contributor): | |||
| logger = logging.getLogger(__name__) | |||
| login = contributor.get('login', None) | |||
| image_url = ('https://avatars.githubusercontent.com/' # Ignore InvalidLinkBear | |||
There was a problem hiding this comment.
E501 line too long (83 > 80 characters)
Origin: PycodestyleBear (E501), Section: all.python.default.
gitmate-bot
reviewed
Jun 2, 2018
data/contrib_data.py
Outdated
| @@ -27,9 +27,12 @@ def get_contrib_data(): | |||
| def import_data(contributor): | |||
| logger = logging.getLogger(__name__) | |||
| login = contributor.get('login', None) | |||
| image_url = ('https://avatars.githubusercontent.com/' # Ignore InvalidLinkBear | |||
There was a problem hiding this comment.
Line is longer than allowed. (83 > 80)
Origin: LineLengthBear, Section: all.linelength.
Travis tests have failedHey @sks444, 2nd Buildcoala --non-interactive -V |
sks444
changed the title
Travis tests have failedHey @sks444, 1st Build./.ci/build.sh |
|
Hi @sks444 Please squash your commits 😇 . |
KVGarg
added a commit
to KVGarg/community
that referenced
this pull request
Feb 12, 2019
This enhancement commit displays the contributor image along with the information on the [community website](http://community.coala.io/contributors/). Closes coala#139 and coala#141
KVGarg
added a commit
to KVGarg/community
that referenced
this pull request
Feb 12, 2019
This enhancement commit displays the contributor image along with the information on the [community website](http://community.coala.io/contributors/). Closes coala#139 and Closes coala#141
KVGarg
added a commit
to KVGarg/community
that referenced
this pull request
Feb 12, 2019
This enhancement commit displays the contributor image along with the information on the [community website](http://community.coala.io/contributors/). Closes coala#139 and Closes coala#141
KVGarg
added a commit
to KVGarg/community
that referenced
this pull request
Feb 12, 2019
This enhancement commit displays the contributor image along with the information on the [community website](http://community.coala.io/contributors/). Closes coala#139, Closes coala#141
KVGarg
added a commit
to KVGarg/community
that referenced
this pull request
Feb 12, 2019
This enhancement commit displays the contributor image along with the information on the [community website](http://community.coala.io/contributors/). Closes coala#139, Closes coala#141
KVGarg
added a commit
to KVGarg/community
that referenced
this pull request
Feb 13, 2019
This enhancement commit displays the contributor image along with the information on the [community website](http://community.coala.io/contributors/). Closes coala#139, Closes coala#141
KVGarg
added a commit
to KVGarg/community
that referenced
this pull request
Jun 13, 2019
KVGarg
added a commit
to KVGarg/community
that referenced
this pull request
Jun 14, 2019
KVGarg
added a commit
to KVGarg/community
that referenced
this pull request
Jun 14, 2019
KVGarg
added a commit
to KVGarg/community
that referenced
this pull request
Jun 14, 2019
KVGarg
added a commit
to KVGarg/community
that referenced
this pull request
Jun 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #139