Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LISP forms don't properly rewrite variables #5

Closed
eliaslfox opened this issue Aug 30, 2021 · 0 comments · Fixed by #42
Closed

LISP forms don't properly rewrite variables #5

eliaslfox opened this issue Aug 30, 2021 · 0 comments · Fixed by #42
Assignees
@eliaslfox
Labels
bug Something isn't working
Milestone
0.1 Release

Comments

@eliaslfox
Copy link
Collaborator

No description provided.

@eliaslfox eliaslfox added the bug Something isn't working label Aug 30, 2021
@eliaslfox eliaslfox self-assigned this Aug 30, 2021
@eliaslfox eliaslfox added this to the 0.1 Release milestone Aug 30, 2021
eliaslfox added a commit that referenced this issue Aug 31, 2021
@eliaslfox
Add variable capture to lisp nodes
f964045 
Previously lisp nodes were rewritten with a code walker to allow them to
access renamed variables. This seemed to fragile so lisp nodes now must
declare which local variables they wish to use. The lisp node's form
will then be wrapped in a let block during codegen which will unrename
the requested variables.

Fixes #5
@eliaslfox eliaslfox mentioned this issue Aug 31, 2021
Merged
eliaslfox added a commit that referenced this issue Aug 31, 2021
@eliaslfox
Add variable capture to lisp nodes
1cfdff4 
Previously lisp nodes were rewritten with a code walker to allow them to
access renamed variables. This seemed to fragile so lisp nodes now must
declare which local variables they wish to use. The lisp node's form
will then be wrapped in a let block during codegen which will unrename
the requested variables.

Fixes #5
eliaslfox added a commit that referenced this issue Aug 31, 2021
@eliaslfox
Add variable capture to lisp nodes
18327d0 
Previously lisp nodes were rewritten with a code walker to allow them to
access renamed variables. This seemed to fragile so lisp nodes now must
declare which local variables they wish to use. The lisp node's form
will then be wrapped in a let block during codegen which will unrename
the requested variables.

Fixes #5
eliaslfox added a commit that referenced this issue Aug 31, 2021
@eliaslfox
Add variable capture to lisp nodes
ac7d849 
Previously lisp nodes were rewritten with a code walker to allow them to
access renamed variables. This seemed to fragile so lisp nodes now must
declare which local variables they wish to use. The lisp node's form
will then be wrapped in a let block during codegen which will unrename
the requested variables.

Fixes #5
eliaslfox added a commit that referenced this issue Aug 31, 2021
@eliaslfox
Add local variable capture to lisp nodes
e058ee6 
Previously lisp nodes were rewritten with a code walker to allow them to
access renamed variables. This seemed to fragile so lisp nodes now must
declare which local variables they wish to use. The lisp node's form
will then be wrapped in a let block during codegen which will unrename
the requested variables.

Fixes #5
eliaslfox added a commit that referenced this issue Aug 31, 2021
@eliaslfox
Add local variable capture to lisp nodes
8831556 
Previously lisp nodes were rewritten with a code walker to allow them to
access renamed variables. This seemed to fragile so lisp nodes now must
declare which local variables they wish to use. The lisp node's form
will then be wrapped in a let block during codegen which will unrename
the requested variables.

Fixes #5
macrologist added a commit to macrologist/coalton that referenced this issue Oct 10, 2023
@macrologist
# This is a combination of 7 commits.
afd9882 
# This is the 1st commit message:

Labels for all loop varieties

more parser tests

# This is the commit message coalton-lang#2:

doh

# This is the commit message coalton-lang#3:

Fix: bad codgen for bare loop

# This is the commit message coalton-lang#4:

Fix: bad parse of while-let node after label feature

# This is the commit message coalton-lang#5:

Add: loop documentation to intro doc

# This is the commit message coalton-lang#6:

requested malarchy

# This is the commit message coalton-lang#7:

more tests; no break/continue from lambdas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eliaslfox eliaslfox

Labels
bug Something isn't working
Projects
None yet
Milestone
0.1 Release
Development

Successfully merging a pull request may close this issue.

Add variable capture to lisp nodes coalton-lang/coalton
1 participant
@eliaslfox