Add variable capture to lisp nodes #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colescott
requested changes
Aug 31, 2021
eliaslfox
force-pushed
the
feature-lisp-form-variable-capture
branch
2 times, most recently
from
1cfdff4
to
18327d0
Compare
colescott
approved these changes
Aug 31, 2021
eliaslfox
force-pushed
the
feature-lisp-form-variable-capture
branch
from
18327d0
to
ac7d849
Compare
Previously lisp nodes were rewritten with a code walker to allow them to access renamed variables. This seemed to fragile so lisp nodes now must declare which local variables they wish to use. The lisp node's form will then be wrapped in a let block during codegen which will unrename the requested variables. Fixes #5
eliaslfox
force-pushed
the
feature-lisp-form-variable-capture
branch
from
ac7d849
to
e058ee6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously lisp nodes were rewritten with a code walker to allow them to
access renamed variables. This seemed to fragile so lisp nodes now must
declare which local variables they wish to use. The lisp node's form
will then be wrapped in a let block during codegen which will unrename
the requested variables.
Fixes #5