Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-convergent balanced trees share same digest #12

Open
MatthieuNICOLAS opened this issue Sep 12, 2017 · 0 comments
Open

Non-convergent balanced trees share same digest #12

MatthieuNICOLAS opened this issue Sep 12, 2017 · 0 comments

Comments

@MatthieuNICOLAS
Copy link
Collaborator

MatthieuNICOLAS commented Sep 12, 2017

Severity: Low

Problem

Two balanced trees with the same totally ordered set of blocks, but distinct because balanced differently, share the same digest.

Consequence

Since we rely mostly on the digest to compare documents models in our tests, this can hide the fact that the models are unexpectedly not strongly convergent.

Possible fix

  • digest() could be updated to take into account the shape of the tree.
  • We could provide another function treeDigest() to keep track separately of the convergence of the content and of the model.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants