Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase out config server #144

Open
monezz opened this issue Aug 25, 2021 · 4 comments · Fixed by #158
Open

Phase out config server #144

monezz opened this issue Aug 25, 2021 · 4 comments · Fixed by #158
Assignees
Labels
enhancement Enhancement of existing functionality in progress

Comments

@monezz
Copy link
Collaborator

monezz commented Aug 25, 2021

TODO

@gr-hovest-atb gr-hovest-atb added the to be discussed Discussion is required as precondition for actually working on this label Aug 25, 2021
@gr-hovest-atb
Copy link
Contributor

For the admin application, it would be quite easy to replace the config server, using custom ygg-admin-[...].yml files for the different profiles (right now there are only a few that are actually in use). They could be combined with environment variables set automatically during deployment.

For the gateways, this will be much more complex, as existing gateways rely on config server to get their config, questions to be discussed:

  • how would gateways get their initial config (put it into the JAR? provide it in a start script? ...)?
  • where would the current config be centrally stored (in yml files? in a database? ...)?
  • how would gateways get config updates (create a new "config refresh API" as it is done for the "api key refresh" mechanism? ...)?

@ChristophBaierATB
Copy link
Contributor

We did not get rid of the config server, yet. It is still required to enable the correct functionality of the Gateways.

@gr-hovest-atb
Copy link
Contributor

The first part of this issue was solved in #158 (remove config server dependency from admin), but the gateway configs still required the config server.

@ChristophBaierATB
Copy link
Contributor

ChristophBaierATB commented Dec 8, 2021

Within the scope of #162 I got rid of the remote BitBucket GitService. Web Application and Config Server exchange proxy configuration files via shared filesystem using a Docker volume instead of git.

@perezdf I think it would make sense to wait until the PR for #162 is merged to continue with this issue as building on that PR would probably ease the process of phasing out the config server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants