Enhancement/144 remove the spring cloud config dependency in admin #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr-hovest-atb
suggested changes
Oct 15, 2021
There was a problem hiding this comment.
I have added several suggestions for improvement to facilitate local development setup in the future. This should be updated and then properly tested before merging, to assure that local development/testing is still possible with only minor adjustments of local setup.
Co-authored-by: gr-hovest-atb <gr-hovest@atb-bremen.de>
BrunoSilvaATB
changed the title
BrunoSilvaATB
changed the title
Co-authored-by: gr-hovest-atb <gr-hovest@atb-bremen.de>
gr-hovest-atb
suggested changes
Nov 9, 2021
Co-authored-by: gr-hovest-atb <gr-hovest@atb-bremen.de>
Co-authored-by: gr-hovest-atb <gr-hovest@atb-bremen.de>
Co-authored-by: gr-hovest-atb <gr-hovest@atb-bremen.de>
Co-authored-by: gr-hovest-atb <gr-hovest@atb-bremen.de>
Co-authored-by: gr-hovest-atb <gr-hovest@atb-bremen.de>
Co-authored-by: gr-hovest-atb <gr-hovest@atb-bremen.de>
|
Created follow-up issue #161 |
gr-hovest-atb
approved these changes
Nov 9, 2021
This was referenced Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the first part of #144 (ygg-admin will not need the config server any more)