update the way we retrieve the proxy template in order to offer the p… #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr-hovest-atb
suggested changes
Oct 8, 2021
spring-boot/admin/src/main/java/eu/coatrack/admin/service/CustomProxyFileGeneratorService.java
Outdated
Show resolved
Hide resolved
spring-boot/admin/src/main/java/eu/coatrack/admin/service/CustomProxyFileGeneratorService.java
Outdated
Show resolved
Hide resolved
| @@ -6,4 +6,4 @@ | |||
| # - a CoatRack build requires some mail configuration parameters to be set | |||
| # - the configuration values in this file are just dummy/fallback values for development builds | |||
|
|
|||
| mvn clean package -Dygg.mail.sender.user="" -Dygg.mail.sender.password="" -Dygg.mail.server.url="" -Dygg.mail.server.port=0 -Dygg.mail.sender.from="" | |||
| mvn clean package -Dygg.mail.sender.user="" -Dygg.mail.sender.password="" -Dygg.mail.server.url="" -Dygg.mail.server.port=0 -Dygg.mail.sender.from="" -Dygg.proxy.executable-jar.template.url="" -Dygg.proxy.executable-jar.generated.path="" | |||
There was a problem hiding this comment.
Wouldn't it be better/easier to move these fallback parameter values into application.yml?
There was a problem hiding this comment.
we will achive these and other movement of variable in a more and specific issue
| @@ -33,5 +33,5 @@ if [ ! -z $1 ]; then | |||
| VM_ARG_SPRING_PROFILE="-Dspring.profiles.active=$1" | |||
| fi | |||
|
|
|||
| java -jar $VM_ARG_SPRING_PROFILE -Dygg.mail.sender.user=$2 -Dygg.mail.sender.password=$3 $COATRACK_JAR_FILE | |||
| java -jar $VM_ARG_SPRING_PROFILE -Xdebug -Xrunjdwp:transport=dt_socket,address=8000,server=y,suspend=y -Dygg.mail.sender.user=$2 -Dygg.mail.sender.password=$3 $COATRACK_JAR_FILE | |||
There was a problem hiding this comment.
Does this mean we want to switch on remote debugging all the time? Maybe have a separate profile or start script for that purpose?
Besides, I read that instead of -Xdebug and -Xrunjdwp it would be more performant to use the parameter -agentlib:jdwp, see: https://stackoverflow.com/questions/138511/what-are-java-command-line-options-to-set-to-allow-jvm-to-be-remotely-debugged
spring-boot/admin/src/main/java/eu/coatrack/admin/service/CustomProxyFileGeneratorService.java
Show resolved
Hide resolved
spring-boot/admin/src/main/java/eu/coatrack/admin/service/CustomProxyFileGeneratorService.java
Outdated
Show resolved
Hide resolved
spring-boot/admin/src/main/java/eu/coatrack/admin/service/CustomProxyFileGeneratorService.java
Outdated
Show resolved
Hide resolved
spring-boot/admin/src/main/java/eu/coatrack/admin/service/CustomProxyFileGeneratorService.java
Outdated
Show resolved
Hide resolved
…omProxyFileGeneratorService.java Co-authored-by: gr-hovest-atb <gr-hovest@atb-bremen.de>
…omProxyFileGeneratorService.java Co-authored-by: gr-hovest-atb <gr-hovest@atb-bremen.de>
…omProxyFileGeneratorService.java Co-authored-by: gr-hovest-atb <gr-hovest@atb-bremen.de>
…omProxyFileGeneratorService.java Co-authored-by: gr-hovest-atb <gr-hovest@atb-bremen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ossibility url