New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination suffix work change the href behaviour? #666
Comments
Hm, it seems that I added a leading I don't know if it's a bug then… |
according to #622 the leading slash is expected. |
After a night of sleep, maybe even if we agreed on this result, the leading slash in for my about page, I have So it's a bit odd I have to remove the slash in href for pagination case. I'll fix that ASAP :) |
Yes, the main thing is to be consistent with regular pagination links. |
fix(pagination_permalink): fixes #666 and adjust tests
I've noticed something today as I've recompiled a cobalt at work. My pagination navigation is like https://github.com/Geobert/blog/blob/master/src/_includes/nav_pagination.liquid
I'm using
"/{{ paginator.previous_index_permalink }}"
inhref
.Before #631, when serving the blog, I got
http://localhost:3000/all/_p/2/
as link.After:
all/_p/2/
which leads nowhere.So basically, I broke it…
Opening this issue to fix it ASAP :)
The text was updated successfully, but these errors were encountered: