fix(pagination): revamp pagination permalink management #631
Conversation
|
Hm, I should have test on my blog before opening the PR, I have a big issue. I'll update the tests to reflect the bug |
|
I don't understand something while serving with cobalt: whereas Why is that? Apart from this weirdness, the code is working |
This is a relative path, so where it leads depends on what page in your site you are starting from. I assume this link is being generated in |
yes! So it's the user's responsibility to add the leading slash again then? |
| } | ||
| let mut attributes = document::permalink_attributes(&doc.front, &doc.file_path); | ||
| let permalink = permalink::explode_permalink(&config.front_permalink, &attributes)?; | ||
| let permalink_path = std::path::Path::new(&permalink); |
There was a problem hiding this comment.
Not sure how I feel about using std::path for manipulating a URI path
There was a problem hiding this comment.
Is there another tool in the std lib to test for extension?
There was a problem hiding this comment.
I'd either handlroll a solution (like we've done with other url stuff) or use Url::path_segments to at least get the last segment and then check for the extension within that.
Correct. We should fix this in the docs. |
|
Looks good! Feel free to cleanup the commits and let me know when you've pushed them |
Geobert
force-pushed
the
pagination-suffix
branch
from
4046119
to
e041aad
Compare
|
@epage Done! |
fixes #622