Deprecate tpl extension #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Technically, deprecate would mean we retain support but discourage usage. But considering people can set their own extensions in the config and that we're not stable yet I'm good with this I think. |
|
Oh, please also update the README (and take a grep through the project for "tpl") to find if you missed anything. |
…ything, thats not the case
|
@johannhof thought missed stuff breaks the test, which was not the case, missed some addtional tpl templates in fixtures folder. Also removed it from the readme. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what I thought when I started out with that .tpl templates.
We use liquid templates therefore the extension should be .liquid
In future maybe we can adapt more template languages where the extension would indicate which template engine to use. But for now liquid-rust is fine.