Add Watch command #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johannhof @tak1n would love if one of you could review this code. It's not fully done and I would love some suggestions for improvement. Thanks! |
|
I'll take a look later today! :) |
| } | ||
| } | ||
| } | ||
| Err(e) => error!("[Notify Error]: {}", e), |
There was a problem hiding this comment.
we should std::process::exit(1) here
|
Luckily cobalt is quite quick right now so the just-rebuild-all approach will work for now, but we should definitely split up the different steps in cobalt.rs into public functions so that we can have at least a tiny bit of "incremental" compilation. |
|
@LucioFranco this is awesome! It's definitely mergeable for me, I left a few minor nits for you anyway :) |
|
👍 |
This was referenced Apr 8, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds watch command and other things:
TODO:
Servecommand now builds the site before serving itWatchcommand builds the site then serves it then waits to see if a file has changed in the source dir and will rebuild on change Add a watch option #51--portflag to pass a port to the server Add a --port option to cobalt serve #76build,watch, andserveLet me know if there is anything else that should be added/changed.