Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for call of kopts_overwrite #2200

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Fix for call of kopts_overwrite #2200

merged 1 commit into from
Nov 13, 2019

Conversation

brejoc
Copy link
Member

@brejoc brejoc commented Nov 13, 2019

kopts_overwrite is in the utils module and that's why the call path has to be fixed.

@brejoc brejoc force-pushed the master-fix-kopts-overwrite-call branch from 752d91c to c279763 Compare November 13, 2019 08:35
@SchoolGuy SchoolGuy self-assigned this Nov 13, 2019
@SchoolGuy SchoolGuy self-requested a review November 13, 2019 08:37
@watologo1 watologo1 merged commit 816f14c into master Nov 13, 2019
@watologo1
Copy link
Contributor

Outch, that was my fault. Thanks.

SchoolGuy
SchoolGuy reviewed Nov 13, 2019
View reviewed changes
Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more occurances without utils so this now catches everything.

@SchoolGuy SchoolGuy deleted the master-fix-kopts-overwrite-call branch June 30, 2020 19:48
@SchoolGuy SchoolGuy added this to the v3.1.0 milestone Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watologo1 watologo1 watologo1 left review comments

@SchoolGuy SchoolGuy SchoolGuy left review comments

Assignees

@SchoolGuy SchoolGuy

Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@brejoc @watologo1 @SchoolGuy