Remove simplejson dependency #2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Conan-Kudo
approved these changes
Mar 23, 2021
nodeg
approved these changes
Mar 23, 2021
| @@ -86,7 +86,7 @@ def serialize_item(collection, item): | |||
|
|
|||
| _dict = item.to_dict() | |||
| with open(filename, "w+") as file_descriptor: | |||
| data = simplejson.dumps(_dict, encoding="utf-8", sort_keys=sort_keys, indent=indent) | |||
There was a problem hiding this comment.
You're removing the encoding due to simplejson defaulting to utf-8, right?
There was a problem hiding this comment.
Nope due to that the keyword simply does not exist: https://docs.python.org/3/library/json.html#json.dumps
Explanation see: https://stackoverflow.com/a/18337754/4730773
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PyPi
simplejsonpackage was integrated into the Python standard library (see: https://github.com/simplejson/simplejson). Thus I removed it since Py 2.6 is already a while in the past now.