simplify remote_boot_file setters #2886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handle empty string to clear property remove unneeded indention. Signed-off-by: Olaf Hering <olaf@aepfle.de>
unify with remote_boot_kernel Signed-off-by: Olaf Hering <olaf@aepfle.de>
Codecov Report
@@ Coverage Diff @@
## master #2886 +/- ##
==========================================
- Coverage 46.82% 46.82% -0.01%
==========================================
Files 101 101
Lines 14457 14453 -4
==========================================
- Hits 6770 6767 -3
+ Misses 7687 7686 -1
Continue to review full report at Codecov.
|
SchoolGuy
approved these changes
Jan 15, 2022
SchoolGuy
requested review from
agraul,
watologo1 and
a team
and removed request for
agraul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.