Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virt_file_size: Use float in all places #3071

Merged
merged 5 commits into from
May 31, 2022
Merged

virt_file_size: Use float in all places #3071

merged 5 commits into from
May 31, 2022

Conversation

SchoolGuy
Copy link
Member

Before there was a mix of int and float. This mix was now converted to float in
all places which is: Docs, Tests, Settings, CLI.

@SchoolGuy SchoolGuy added this to the v3.4.0 milestone Apr 22, 2022
@SchoolGuy SchoolGuy requested a review from a team April 22, 2022 14:39
@github-actions github-actions bot added documentation Improvements or additions to documentation tests labels Apr 22, 2022
@SchoolGuy SchoolGuy marked this pull request as draft April 22, 2022 15:02
@SchoolGuy
Copy link
Member Author

This PR should contain the forward port of V3.3.3 once the PR for #3072 is approved.

@SchoolGuy
Copy link
Member Author

PR was approved. After 3.3.3 was released in the coming days, I will rebase this PR and incorporate the changes here.

@github-actions github-actions bot added the CI CI/CD related label Apr 25, 2022
@SchoolGuy
Copy link
Member Author

Okay I now rebased onto main and cherry picked the commits as needed. Thus we need to put this on hold until we released 3.3.3

@SchoolGuy SchoolGuy force-pushed the fix/virt_file_size branch 2 times, most recently from 03d16e1 to 027d77c Compare May 19, 2022 09:06
@SchoolGuy SchoolGuy marked this pull request as ready for review May 31, 2022 12:14
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #3071 (ebe3a91) into main (132aefa) will decrease coverage by 0.05%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##             main    #3071      +/-   ##
==========================================
- Coverage   62.49%   62.43%   -0.06%     
==========================================
  Files         102      103       +1     
  Lines       14491    14506      +15     
==========================================
+ Hits         9056     9057       +1     
- Misses       5435     5449      +14     
Impacted Files Coverage Δ
cobbler/cli.py 65.13% <ø> (ø)
cobbler/settings/migrations/V3_4_0.py 92.30% <66.66%> (ø)
cobbler/settings/migrations/V3_3_3.py 93.33% <93.33%> (ø)
cobbler/items/image.py 84.47% <100.00%> (ø)
cobbler/settings/__init__.py 88.01% <100.00%> (ø)
cobbler/validate.py 83.57% <100.00%> (ø)
cobbler/autoinstall_manager.py 67.28% <0.00%> (-4.94%) ⬇️
cobbler/cobbler_collections/collection.py 74.66% <0.00%> (-0.89%) ⬇️
cobbler/items/profile.py 94.24% <0.00%> (-0.61%) ⬇️
cobbler/autoinstallgen.py 11.29% <0.00%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 132aefa...ebe3a91. Read the comment docs.

Copy link
Contributor

@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@SchoolGuy SchoolGuy merged commit dd45e6e into main May 31, 2022
@SchoolGuy SchoolGuy deleted the fix/virt_file_size branch May 31, 2022 14:52
@SchoolGuy SchoolGuy linked an issue Jun 3, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI/CD related documentation Improvements or additions to documentation tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

virt_file_size has different types
2 participants