-
-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virt_file_size: Use float in all places #3071
Conversation
This PR should contain the forward port of V3.3.3 once the PR for #3072 is approved. |
PR was approved. After 3.3.3 was released in the coming days, I will rebase this PR and incorporate the changes here. |
cb3a322
to
1c98f0f
Compare
Okay I now rebased onto |
1c98f0f
to
2d800db
Compare
03d16e1
to
027d77c
Compare
Before there was a mix of int and float. This mix was now converted to float in all places which is: Docs, Tests, Settings, CLI.
027d77c
to
ebe3a91
Compare
Codecov Report
@@ Coverage Diff @@
## main #3071 +/- ##
==========================================
- Coverage 62.49% 62.43% -0.06%
==========================================
Files 102 103 +1
Lines 14491 14506 +15
==========================================
+ Hits 9056 9057 +1
- Misses 5435 5449 +14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Before there was a mix of int and float. This mix was now converted to float in
all places which is: Docs, Tests, Settings, CLI.