Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added backport fix for reposync #3227

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Conversation

c4t3l
Copy link

@c4t3l c4t3l commented Aug 11, 2022

Linked Items

Fixes #2865 for v3.2.2 which is the current supported stable branch in epel8.

Description

This PR backports some of the changes presented in #2942. Namely, the librepo "Cannot create output directory" error and the missing noarch package downloads referenced in this comment

Behaviour changes

Old: Reposyncs fail on consecutive runs and noarch packages are ignored in repos.

New: Reposyncs pass on consecutive runs and noarch packages are downloaded.

Category

This is related to a:

  • Bugfix
  • Feature
  • Packaging
  • Docs
  • Code Quality
  • Refactoring
  • Miscellaneous

Tests

  • Unit-Tests were created
  • System-Tests were created
  • Code is already covered by Unit-Tests
  • Code is already covered by System-Tests
  • No tests required

@SchoolGuy SchoolGuy added this to the V3.2.3 milestone Aug 15, 2022
Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for using the issue template. That makes this a lot easier. I have some comments that I would love if we address them before we merge this PR.

cobbler/actions/reposync.py Show resolved Hide resolved
cobbler/actions/reposync.py Show resolved Hide resolved
cobbler/actions/reposync.py Show resolved Hide resolved
Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchoolGuy
Copy link
Member

@c4t3l Could you sign the commits please? (And if possible squash the fix and revert fix into the main commit)

@c4t3l
Copy link
Author

c4t3l commented Aug 19, 2022

@SchoolGuy, sure thing. I will do that once I get back home.

@c4t3l
Copy link
Author

c4t3l commented Aug 23, 2022

Please let me know if there is anything else required.

@SchoolGuy SchoolGuy merged commit 453a33b into cobbler:release32 Aug 23, 2022
@SchoolGuy
Copy link
Member

@c4t3l Nope all was fine now. This PR just slipped under my radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants