Fix issues on settings migrations and migrate collections to latest 3.3.0 schema. #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
SchoolGuy
reviewed
Sep 24, 2022
meaksh
changed the title
meaksh
force-pushed
the
main-fix-settings-migrations
branch
2 times, most recently
from
ff7356c
to
a4518b1
Compare
Codecov ReportBase: 65.82% // Head: 65.72% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3258 +/- ##
==========================================
- Coverage 65.82% 65.72% -0.11%
==========================================
Files 112 113 +1
Lines 15006 15151 +145
==========================================
+ Hits 9878 9958 +80
- Misses 5128 5193 +65
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
meaksh
changed the title
SchoolGuy
requested changes
Oct 4, 2022
meaksh
force-pushed
the
main-fix-settings-migrations
branch
from
1bdf263
to
9a08da5
Compare
|
@SchoolGuy I've rebased the commits and I hope commit history is better now. |
|
Wait, I found some issue, something was last during the rebase. I'll update the branch again in a moment. |
meaksh
force-pushed
the
main-fix-settings-migrations
branch
from
9a08da5
to
dae47c2
Compare
|
@SchoolGuy this should be fine now 👍 |
|
@meaksh Codacy has some very valid concerns about your PR. Please have a look at them. For example the fact that you use lists as default arguments is problematic. (This was a bug in another part of Cobbler already.) |
meaksh
force-pushed
the
main-fix-settings-migrations
branch
from
12b42a2
to
c9f8ec6
Compare
The migration of stored Cobbler collections will now happen as part of the migration of 3.3.0 settings. Additionally it fixes possible old ipmitool setting to new default. A backup from old collections will be created at /var/lib/cobbler/
This commit introduces new logic that allows to preserve and exclude custom extra settings from validation and migration. A new parameter has been introduced to cobbler-settings, "--preserve-settings" as well as a new settings named "extra_settings_list" to allow defining your own custom settings to be excluded from validation.
Also around handling extra_settings_list settings Additionally this fixes small issues found.
meaksh
force-pushed
the
main-fix-settings-migrations
branch
from
c9f8ec6
to
bcf24bc
Compare
SchoolGuy
requested changes
Oct 6, 2022
Additionally also uses proper Tuple for type annotation
meaksh
force-pushed
the
main-fix-settings-migrations
branch
from
00ba798
to
8fd572e
Compare
If "next_server" is a hostname and not an IPv4 nor IPv6 address then we try to resolve this hostname to fill the corresponding new "next_server_v4" and "next_server_v6" settings. If resolution does not work for any of those settings, and error is printed and migration of "next_server" is not performed.
meaksh
force-pushed
the
main-fix-settings-migrations
branch
from
8fd572e
to
c3b20e9
Compare
SchoolGuy
reviewed
Oct 21, 2022
12 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Items
settings.dmix prevents upgrade from 3.1.2 to 3.3.0 #3262Description
This PR fixes some issues around settings and migrations:
cobbler-settingscommand to allow passing settings to exclude from migration with--preserve-settings. This will fix Allow settings of custom plugins to be preserved with migrations #3261 andsettings.dmix prevents upgrade from 3.1.2 to 3.3.0 #3262)extra_settings_listto define list of custom settings the user wants to exclude from the migration/validation.power_management_default_typesetting fromipmitooltoipmilanplusmanage_tftpsettings after version 3.2.1.Category
This is related to a:
Tests