-
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues on settings migrations and migrate collections to latest 3.3.0 schema. #3258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions, some frowning but overall looking already quite good.
ff7356c
to
a4518b1
Compare
Codecov ReportBase: 65.82% // Head: 65.72% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3258 +/- ##
==========================================
- Coverage 65.82% 65.72% -0.11%
==========================================
Files 112 113 +1
Lines 15006 15151 +145
==========================================
+ Hits 9878 9958 +80
- Misses 5128 5193 +65
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Git history is very messy. Please group the commits in a way that one can understand the changes by looking at the individual commits.
1bdf263
to
9a08da5
Compare
@SchoolGuy I've rebased the commits and I hope commit history is better now. |
Wait, I found some issue, something was last during the rebase. I'll update the branch again in a moment. |
9a08da5
to
dae47c2
Compare
@SchoolGuy this should be fine now 👍 |
@meaksh Codacy has some very valid concerns about your PR. Please have a look at them. For example the fact that you use lists as default arguments is problematic. (This was a bug in another part of Cobbler already.) |
12b42a2
to
c9f8ec6
Compare
The migration of stored Cobbler collections will now happen as part of the migration of 3.3.0 settings. Additionally it fixes possible old ipmitool setting to new default. A backup from old collections will be created at /var/lib/cobbler/
This commit introduces new logic that allows to preserve and exclude custom extra settings from validation and migration. A new parameter has been introduced to cobbler-settings, "--preserve-settings" as well as a new settings named "extra_settings_list" to allow defining your own custom settings to be excluded from validation.
Also around handling extra_settings_list settings Additionally this fixes small issues found.
c9f8ec6
to
bcf24bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please investigate why Debian 10 and Rocky Linux 8 reliably fail with your PR. I previously overlooked that sadly. Please also mind the rest of the comments I now was able to spot. The Git history looks very nice now!
Additionally also uses proper Tuple for type annotation
00ba798
to
8fd572e
Compare
If "next_server" is a hostname and not an IPv4 nor IPv6 address then we try to resolve this hostname to fill the corresponding new "next_server_v4" and "next_server_v6" settings. If resolution does not work for any of those settings, and error is printed and migration of "next_server" is not performed.
8fd572e
to
c3b20e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Linked Items
settings.d
mix prevents upgrade from 3.1.2 to 3.3.0 #3262Description
This PR fixes some issues around settings and migrations:
cobbler-settings
command to allow passing settings to exclude from migration with--preserve-settings
. This will fix Allow settings of custom plugins to be preserved with migrations #3261 andsettings.d
mix prevents upgrade from 3.1.2 to 3.3.0 #3262)extra_settings_list
to define list of custom settings the user wants to exclude from the migration/validation.power_management_default_type
setting fromipmitool
toipmilanplus
manage_tftp
settings after version 3.2.1.Category
This is related to a:
Tests