Add static typing

[SchoolGuy]

Linked Items

Fixes #3314

Description

Introduce strict mypy checking.

Behaviour changes

Old: None

New: None

Category

This is related to a:

• Bugfix
• Feature
• Packaging
• Docs
• Code Quality
• Refactoring
• Miscellaneous

Tests

• Unit-Tests were created
• System-Tests were created
• Code is already covered by Unit-Tests
• Code is already covered by System-Tests
• No tests required

[SchoolGuy]

This took a lot of ignores but the PR is getting in a good shape. The tests need to be fixed obviously but other than that there should be not many changes required to make the CI.

[codecov]

Codecov Report

Patch coverage: 65.07% and project coverage change: +64.64 🎉

Comparison is base (5c76a58) 0.19% compared to head (53e26a3) 64.83%.

❗ Current head 53e26a3 differs from pull request most recent head 7d3d48f. Consider uploading reports for the commit 7d3d48f to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##            main    #3315       +/-   ##
==========================================
+ Coverage   0.19%   64.83%   +64.64%     
==========================================
  Files         93      113       +20     
  Lines      12983    15788     +2805     
==========================================
+ Hits          25    10236    +10211     
+ Misses     12958     5552     -7406     

Impacted Files	Coverage Δ
cobbler/api.py	70.06% <ø> (+70.06%)	⬆️
cobbler/cobblerd.py	0.00% <0.00%> (ø)
cobbler/items/image.py	88.54% <ø> (+88.54%)	⬆️
cobbler/items/item.py	86.33% <ø> (+86.33%)	⬆️
cobbler/items/menu.py	81.42% <ø> (ø)
cobbler/items/mgmtclass.py	89.39% <ø> (+89.39%)	⬆️
cobbler/items/package.py	91.89% <ø> (+91.89%)	⬆️
cobbler/items/profile.py	94.61% <ø> (+94.61%)	⬆️
cobbler/items/repo.py	85.00% <ø> (+85.00%)	⬆️
cobbler/items/resource.py	91.42% <ø> (ø)
... and 103 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[SchoolGuy]

This PR needs to be rebased as soon as #3363 is merged. The PR is a split-out from the previously mentioned PR.

[SchoolGuy]

Rebase is in progress. However, it appears there are some errors that are in need of fixing.

[codacy-production]

Coverage summary from Codacy

Merging #3315 (c2ebdef) into main (ad95448) - See PR on Codacy

Coverage variation	Diff coverage
-0.68%	68.44%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (ad95448)	13886	9316	67.09%
Head commit (c2ebdef)	14394 (+508)	9559 (+243)	66.41% (-0.68%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#3315)	2582	1767	68.44%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

[SchoolGuy]

Rebase after isort PR merge.

[SchoolGuy]

All linters are happy. The type system in Cobbler is far from being perfect because I require a lot of ignores (too many IMHO) to make them happy but as a first version this should do. We can improve this later on if needed.

[SchoolGuy]

LDAP tests are sadly failing. This is happening already for quite a while so I will ignore it for this PR.

[SchoolGuy]

Reviewing this doesn't make much sense. We can fixup the bugs later on.