Add missing functionallity #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchoolGuy
force-pushed
the
feature/add-actions
branch
4 times, most recently
from
730a664
to
d26f7dd
Compare
SchoolGuy
force-pushed
the
feature/add-actions
branch
from
316266a
to
eb84e5a
Compare
SchoolGuy
force-pushed
the
feature/add-actions
branch
from
a5df703
to
2d450ed
Compare
SchoolGuy
force-pushed
the
feature/add-actions
branch
2 times, most recently
from
d416451
to
4033e31
Compare
Merged
SchoolGuy
force-pushed
the
feature/add-actions
branch
from
7bfc669
to
4159b11
Compare
|
The missing functionality is there but it breaks the test cases. The reason why this is still in draft mode is the following observation: #4 (comment) For ideas and discussion please use the issue. |
|
After cobbler/cobbler#3293 was merged. This PR will get attention again. |
SchoolGuy
force-pushed
the
feature/add-actions
branch
2 times, most recently
from
05cc0d8
to
9da4b13
Compare
SchoolGuy
force-pushed
the
feature/add-actions
branch
from
649dc22
to
5ac96d7
Compare
|
This PR is a lost cause IMHO. I never got it working and as such it is useless. It will be superseded by a new one that I got working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
This PR tries to implement the missing functionality in this library to enable the CLI to fully work as intended.
Edit: Updates for the status of the PR will be done in the issue. The TODO list there gives us a better method of measuring the progress.