#379 Try with resources - net.sourceforge.cobertura.javancss.parser.… #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.parser.ParseException: Encountered " ")" ") "" Try resource block can have semicolon at the end of variable definition and not have another variable. Java compiler will allow one additional semicolon, but Cobertura throws exception because that code was broken when update for Java 7 was made. cobertura#379
|
Travis build was successful with my changes. |
…ndency. - Updated Java version to 1.7. - Restructured Maven projects in order to create easy to consume "cobertura.jar" Core Library. - Moved web (coberturaFlush.war) files to it's own module, called cobertura-flush-war. This project build war package and contains only servlet class, test classes, and needed web.xml configuration. - Moved final stand-alone tool creation to new cobertura-assembly module. This maven (pom) project is only responsible for building tool's packge (in zip, tar, etc. format) that includes Cobertura Core library, Cobertura Flush Servlet WAR, and all needed dependencies as well as scripts, examples and (logback) logging configuration. - Re-factored pom.xml to proper structure and inheritance. Cobertura 2.1.1 uses slf4j binding logback-classic cobertura#36 mojohaus/cobertura-maven-plugin#36
|
I have also fixed the ; problem with the try with resource in my pull request. Also in the javancss project. It's nice to see some action around the project. It would be nice to have a new version too... :) |
|
Thanks @herenyi |
|
@msiemczyk @herenyi @lewijw @dennisl thank you for contributing to Cobertura! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ParseException: Encountered " ")" ") ""
Try resource block can have semicolon at the end of variable definition and not have another variable. Java compiler will allow one additional semicolon, but Cobertura throws exception because that code was broken when update for Java 7 was made.
#379
I few additional changes I didn't really mean to, but you can skip those during the merge if you want.