Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Connection String URI Format #40

Closed
ghost opened this issue Mar 16, 2015 · 5 comments
Closed

Using Connection String URI Format #40

ghost opened this issue Mar 16, 2015 · 5 comments
Assignees

Comments

@ghost
Copy link

ghost commented Mar 16, 2015

Hi,

Is that possible to add the Standard Connection String Format (http://docs.mongodb.org/manual/reference/connection-string/#standard-connection-string-format)

I am writing this issue at http://stackoverflow.com/questions/29030257/flask-mongoalchemy-with-multi-hosts-urls

Cheers

@fsouza
Copy link
Contributor

fsouza commented Mar 17, 2015

Hi @daknightproductions, currently it is not, but it's quite easy to do so. Do you wanna send a patch?

Currently, the code builds the URI from the configuration parameters [1]. We can add a new configuration parameter for the URI, and then the code won't need to build it.

[1] https://github.com/cobrateam/flask-mongoalchemy/blob/master/flask_mongoalchemy/__init__.py#L22:L50

@ghost
Copy link
Author

ghost commented Mar 17, 2015

Hey there,

Well of course it's easy to hack it but i think it's nice to let other
people to have it too, especially if we use pip install. If you have time
in the future, please add 1 extra param which take a whole uri and just
return it if it is not empty....or something better :)

Cheers

Många varma kramar
Oai Gudmundsson

http://daknight.se
Web Dev 3.0
Oai Gudmundsson
+46812061700

On Tue, Mar 17, 2015 at 2:57 AM, Francisco Souza notifications@github.com
wrote:

Hi @daknightproductions https://github.com/daknightproductions,
currently it is not, but it's quite easy to do so. Do you wanna send a
patch?

Currently, the code builds the URI from the configuration parameters [1].
We can add a new configuration parameter for the URI, and then the code
won't need to build it.

[1]
https://github.com/cobrateam/flask-mongoalchemy/blob/master/flask_mongoalchemy/__init__.py#L22:L50


Reply to this email directly or view it on GitHub
#40 (comment)
.

@fsouza
Copy link
Contributor

fsouza commented Mar 17, 2015

Sure, I will do it later today. Thanks for reporting it!

@fsouza fsouza self-assigned this Mar 17, 2015
fsouza added a commit that referenced this issue Mar 17, 2015
fsouza added a commit that referenced this issue Mar 17, 2015
@fsouza
Copy link
Contributor

fsouza commented Mar 17, 2015

It's fixed and released, please upgrade to the version 0.7.1.

Thanks for reporting!

@fsouza fsouza closed this as completed Mar 17, 2015
@ghost
Copy link
Author

ghost commented Mar 17, 2015

Thank you very much! :)

Många varma kramar
Oai Gudmundsson

http://daknight.se
Web Dev 3.0
Oai Gudmundsson
+46812061700

On Tue, Mar 17, 2015 at 5:04 PM, Francisco Souza notifications@github.com
wrote:

It's fixed and released, please upgrade to the version 0.7.1.

Thanks for reporting!


Reply to this email directly or view it on GitHub
#40 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant