Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sending a list of cookie dicts to CookieManager.add() #799

Merged
merged 2 commits into from
Jul 1, 2021

Conversation

jsfehler
Copy link
Collaborator

Adding cookies with a list, eg:

my_list = [{...}, {...}]
CookieManager.add(my_list)

has always been undocumented. Having an argument that takes multiple types seems like a bad idea. If a user really wants to add multiple cookies, it's more likely they're doing:

for c in cookies:
    CookieManager.add(c)

@andrewsmedina
Copy link
Member

We should not make break changes without a deprecation warning. So @jsfehler what do you think in 0.15 support the both ways and add a deprecation warning (an example here:

) and in the 0.16 we can remove the old way?

@jsfehler
Copy link
Collaborator Author

jsfehler commented Sep 8, 2020

@andrewsmedina Makes sense to me. See #801

@jsfehler jsfehler merged commit ca54dfc into cobrateam:master Jul 1, 2021
@jsfehler jsfehler deleted the no_cookie_list branch July 1, 2021 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants