Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some bugs #160

Closed
wants to merge 3 commits into from
Closed

fix some bugs #160

wants to merge 3 commits into from

Conversation

xiaozhuai
Copy link

@xiaozhuai xiaozhuai commented Dec 19, 2017 •
edited
Loading

  1. Construct method same name with class is deprecated, use __construct. In file web/application/libraries/phpass-0.1/PasswordHash.php
  2. In some situation, http/https judgement not work, fixed. In file web/system/core/Config.php
  3. Unified deviceid length 128 for all table

cobub
cobub approved these changes May 22, 2018
View reviewed changes
Copy link
Owner

@cobub cobub left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! what you changed is the core code of CI framework in the following changes:

  • fix http/https judgement <237a823>
  • fix http/https judgement <237a823>

which could not be merged into the master branch. please resubmit PR

@cobub cobub requested review from brucenan and zxial May 22, 2018 12:36
@xiaozhuai xiaozhuai closed this Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cobub cobub cobub approved these changes

@brucenan brucenan Awaiting requested review from brucenan

@zxial zxial Awaiting requested review from zxial

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaozhuai @cobub