Skip to content
This repository has been archived by the owner on Feb 20, 2020. It is now read-only.

improve performance for group page #142

Closed
data-doge opened this issue Apr 21, 2016 · 5 comments
Closed

improve performance for group page #142

data-doge opened this issue Apr 21, 2016 · 5 comments

Comments

@data-doge
Copy link
Contributor

screen shot 2016-04-21 at 1 24 31 pm

42 seconds is too long for the group page to load

@Connoropolous
Copy link
Contributor

I've been wondering about that a bit too...

In metamaps, we bootstrap the inclusion of the models into the page, but we
can do that because we're using .erb which are ruby templates, and not
everything has to happen over the API...
https://github.com/metamaps/metamaps/blob/develop/app/views/maps/show.html.erb

On Thu, Apr 21, 2016 at 4:25 PM, Eugene Lynch notifications@github.com
wrote:

[image: screen shot 2016-04-21 at 1 24 31 pm]
https://cloud.githubusercontent.com/assets/7520103/14723153/6f9983b0-07c4-11e6-98b5-f5e9e9993d3d.png

42 seconds is too long for the group page to load


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#142

Connor Turland
to craft a sustainable and thriving culture within and without myself
co-creator of Metamaps.cc

@kiesia
Copy link
Contributor

kiesia commented Aug 11, 2016

I've made a pull request that will help with this: #146 There's likely couple more refactorings to make.

@kiesia
Copy link
Contributor

kiesia commented Aug 11, 2016

MembershipsController#index and MembershipsController#my_memberships are also problems, I'll take a look at them too. I think it's the same problem with balance calculations.

@kiesia
Copy link
Contributor

kiesia commented Aug 12, 2016

Just looking at the responses in the slow queries, they are all hitting the group serializer. So let's get #146 merged in and then look if there are further optimisations to make.

@kiesia
Copy link
Contributor

kiesia commented Aug 17, 2016

@data-doge @gardner can we close this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants