Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactionalize #9

Merged
merged 7 commits into from
Sep 30, 2014
Merged

Transactionalize #9

merged 7 commits into from
Sep 30, 2014

Conversation

nelz9999
Copy link
Contributor

This is the candidate work to address Issue #6.

Builds upon PR #8...

Most of the changes are procedural, but the change in OnBeep@11ac6eb affects the randomness of the ephemeral values by sacrificing a single bit (out of 256) of entropy in favor of enforcing a 32-byte representation.

@nelz9999
Copy link
Contributor Author

Also, for symmetry's sake, I added the functionality to both sides: Verifier (bytes_b) and User (bytes_a).

@nelz9999
Copy link
Contributor Author

@cocagne Is there anything I can do to ease the integration of this?

@cocagne
Copy link
Owner

cocagne commented Sep 17, 2014

Thanks Nelz. I'm currently attending the Storage Developers Conference and
probably won't be able to take a look at your patches for a few more days.
I'll let you know as soon as I get the chance.

Tom
On Sep 17, 2014 9:53 AM, "Nelz" notifications@github.com wrote:

@cocagne https://github.com/cocagne Is there anything I can do to ease
the integration of this?


Reply to this email directly or view it on GitHub
#9 (comment).

@cocagne
Copy link
Owner

cocagne commented Sep 22, 2014

Looks really good overall Nelz. Just a few standard pointer handling issues and memory leaks to address before merging.

@nelz9999
Copy link
Contributor Author

I've addressed most of your comments, except for the bit around single- vs. double-pointers, which I commented on above.

(Please pardon my slowness, it's been a LONG time since I've done any C, and I've been super reliant on https://github.com/radii for his C excellence.)

cocagne added a commit that referenced this pull request Sep 30, 2014
Transactionalize, courtesy of nelz9999
@cocagne cocagne merged commit ea0d47c into cocagne:master Sep 30, 2014
@nelz9999
Copy link
Contributor Author

Awesome! Thanks!

@cocagne
Copy link
Owner

cocagne commented Oct 1, 2014

No problem. Thanks for the patch. If you don't see the new version up on
pypi in the next couple of days, ping me.

Tom

On Tue, Sep 30, 2014 at 1:09 PM, Nelz notifications@github.com wrote:

Awesome! Thanks!


Reply to this email directly or view it on GitHub
#9 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants