images: Build rhel-8-4 from official qcow image #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
image-refresh in progress on 3-ci-srv-01. |
cockpituous
changed the title
|
image-refresh rhel-8-4 done: https://github.com/cockpituous/bots/commits/image-refresh-rhel-8-4-20210105-065050 |
cockpituous
changed the title
|
The previous refresh took 1219s . Image size was 2.47 GB. This refresh took just 891 s and image size is roughly the same (2.46 GB). |
cockpituous
changed the title
cockpituous
changed the title
cockpituous
changed the title
cockpituous
changed the title
|
While the first image refresh still worked, the image now literally disappeared from the current compose. Blocking until they come back. |
|
I am temporarily putting back the initial (still slightly broken) image refresh so that I can test my cockpit-composer fix. |
martinpitt
pushed a commit
to martinpitt/cockpit-composer
that referenced
this pull request
Jan 5, 2021
Some of our images, like centos-8-stream, are already built from the official cloud images instead of virt-install with LVM. More images are going to do that soon [1], so fix vm.install to only do the LVM grow steps if the image actually uses LVM. [1] cockpit-project/bots#1518
cockpituous
changed the title
|
image-refresh in progress on 4-ci-srv-06. |
|
image-refresh rhel-8-4 done: https://github.com/cockpituous/bots/commits/image-refresh-rhel-8-4-20210105-154444 |
cockpituous
changed the title
martinpitt
pushed a commit
to osbuild/cockpit-composer
that referenced
this pull request
Jan 5, 2021
Some of our images, like centos-8-stream, are already built from the official cloud images instead of virt-install with LVM. More images are going to do that soon [1], so fix vm.install to only do the LVM grow steps if the image actually uses LVM. [1] cockpit-project/bots#1518
|
Apparently we lost /etc/crypttab on the image, and we need to adjust our tests or even the code to get along without it. Or bring back cryptsetup onto the image, I need to check this locally. |
Starting from the cloud image is faster, more robust, and more realistic (using an official product) than our own virt-install bootstrap. Teach cloudimage.bootstrap to get along with redirects, as download.devel.redhat.com is a geolocation mirror. The cloud images don't ship an empty /etc/crypttab, which uncovered a bug in our storage page or in udisks: cockpit-project/cockpit#15100 Create an empy file in the install script to work around that for now.
|
I reported the crypttab failure as cockpit-project/cockpit#15100 , this is real -- this kinda shows the point of testing this on more variety of image types. This should be green now, ready for review. |
|
There is one remaining test case failure as this new image does not have swap. I sent a fix for that to cockpit-project/cockpit#15104 |
|
All landed, unblocked |
8 tasks
martinpitt
pushed a commit
to martinpitt/cockpit-composer
that referenced
this pull request
Jan 7, 2021
Some of our images, like centos-8-stream, are already built from the official cloud images instead of virt-install with LVM. More images are going to do that soon [1], so fix vm.install to only do the LVM grow steps if the image actually uses LVM. [1] cockpit-project/bots#1518 Cherry-picked from master commit d1fa01f
This was referenced Jan 7, 2021
henrywang
pushed a commit
to osbuild/cockpit-composer
that referenced
this pull request
Jan 8, 2021
Some of our images, like centos-8-stream, are already built from the official cloud images instead of virt-install with LVM. More images are going to do that soon [1], so fix vm.install to only do the LVM grow steps if the image actually uses LVM. [1] cockpit-project/bots#1518 Cherry-picked from master commit d1fa01f
jkozol
pushed a commit
to jkozol/welder-web
that referenced
this pull request
Jan 8, 2021
Some of our images, like centos-8-stream, are already built from the official cloud images instead of virt-install with LVM. More images are going to do that soon [1], so fix vm.install to only do the LVM grow steps if the image actually uses LVM. [1] cockpit-project/bots#1518 Cherry-picked from master commit d1fa01f
jkozol
pushed a commit
to jkozol/welder-web
that referenced
this pull request
Jan 8, 2021
Some of our images, like centos-8-stream, are already built from the official cloud images instead of virt-install with LVM. More images are going to do that soon [1], so fix vm.install to only do the LVM grow steps if the image actually uses LVM. [1] cockpit-project/bots#1518 Cherry-picked from master commit d1fa01f
jkozol
pushed a commit
to jkozol/welder-web
that referenced
this pull request
Jan 8, 2021
Some of our images, like centos-8-stream, are already built from the official cloud images instead of virt-install with LVM. More images are going to do that soon [1], so fix vm.install to only do the LVM grow steps if the image actually uses LVM. [1] cockpit-project/bots#1518 Cherry-picked from master commit d1fa01f
martinpitt
added a commit
to weldr/lorax
that referenced
this pull request
Jan 8, 2021
Some of our images, like centos-8-stream, are already built from the official cloud images instead of virt-install with LVM. More images are going to do that soon [1][2], so fix vm.install to only do the LVM grow steps if the image actually uses LVM. Also adjust the comment, as commit 6ddaa5e fixed this for RHEL images. [1] cockpit-project/bots#1518 [2] cockpit-project/bots#1527
martinpitt
added a commit
to weldr/lorax
that referenced
this pull request
Jan 8, 2021
Some of our images, like centos-8-stream, are already built from the official cloud images instead of virt-install with LVM. More images are going to do that soon [1][2], so fix vm.install to only do the LVM grow steps if the image actually uses LVM. Also adjust the comment, as commit 6ddaa5e fixed this for RHEL images. [1] cockpit-project/bots#1518 [2] cockpit-project/bots#1527 (cherry-picked from commit 04ce221)
bcl
pushed a commit
to weldr/lorax
that referenced
this pull request
Feb 8, 2021
Some of our images, like centos-8-stream, are already built from the official cloud images instead of virt-install with LVM. More images are going to do that soon [1][2], so fix vm.install to only do the LVM grow steps if the image actually uses LVM. Also adjust the comment, as commit 6ddaa5e fixed this for RHEL images. [1] cockpit-project/bots#1518 [2] cockpit-project/bots#1527 (cherry picked from commit 04ce221)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from the cloud image is faster, more robust, and more realistic
(using an official product) than our own virt-install bootstrap.
Teach cloudimage.bootstrap to get along with redirects, as
download.devel.redhat.com is a geolocation mirror.