Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: Build rhel-8-3 from official qcow image #1527

Merged
merged 2 commits into from
Jan 16, 2021

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Jan 7, 2021

Starting from the cloud image is faster, more robust, and more realistic
(using an official product) than our own virt-install bootstrap.

Teach cloudimage.bootstrap to get along with redirects, as
download.devel.redhat.com is a geolocation mirror.

Fixes #1522

  • image-refresh rhel-8-3

@martinpitt martinpitt added the bot label Jan 7, 2021
@cockpituous cockpituous changed the title images: Build rhel-8-3 from official qcow image WIP: 4-ci-srv-05: [no-test] images: Build rhel-8-3 from official qcow image Jan 7, 2021
@cockpituous
Copy link
Contributor

image-refresh in progress on 4-ci-srv-05.
Log: https://logs.cockpit-project.org/logs/image-refresh-1527-20210107-074040/

@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: 4-ci-srv-05: [no-test] images: Build rhel-8-3 from official qcow image images: Build rhel-8-3 from official qcow image Jan 7, 2021
@cockpituous cockpituous changed the title images: Build rhel-8-3 from official qcow image WIP: 2-ci-srv-02: [no-test] images: Build rhel-8-3 from official qcow image Jan 7, 2021
@cockpituous
Copy link
Contributor

image-refresh in progress on 2-ci-srv-02.
Log: https://logs.cockpit-project.org/logs/image-refresh-1527-20210107-074444/

@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: 2-ci-srv-02: [no-test] images: Build rhel-8-3 from official qcow image images: Build rhel-8-3 from official qcow image Jan 7, 2021
martinpitt added a commit to weldr/lorax that referenced this pull request Jan 8, 2021
Some of our images, like centos-8-stream, are already built from the
official cloud images instead of virt-install with LVM. More images are
going to do that soon [1][2], so fix vm.install to only do the LVM grow
steps if the image actually uses LVM.

Also adjust the comment, as commit 6ddaa5e fixed this for
RHEL images.

[1] cockpit-project/bots#1518
[2] cockpit-project/bots#1527
martinpitt added a commit to weldr/lorax that referenced this pull request Jan 8, 2021
Some of our images, like centos-8-stream, are already built from the
official cloud images instead of virt-install with LVM. More images are
going to do that soon [1][2], so fix vm.install to only do the LVM grow
steps if the image actually uses LVM.

Also adjust the comment, as commit 6ddaa5e fixed this for
RHEL images.

[1] cockpit-project/bots#1518
[2] cockpit-project/bots#1527

(cherry-picked from commit 04ce221)
@martinpitt martinpitt removed the blocked label Jan 8, 2021
@martinpitt
Copy link
Member Author

martinpitt commented Jan 13, 2021

Fixing TestUpdatesSubscriptions was simple (sub-man is disabled by default on the cloud image), but TestLogin.testExpired is more subtle: This really is a bug in RHEL 8.3, which we already found long ago in gating -- that's why we disabled the test downstream for Fedora 31 and RHEL.

This seems to work fine on RHEL 8.4 (as we already use the cloud image there). I want to see if that's something obvious in the PAM config, otherwise I'll just file a naughty for it.

Update: Found it, we already adjusted that for centos-8-stream in 289ddc5

@martinpitt
Copy link
Member Author

martinpitt commented Jan 14, 2021

That should do it. I'll clean this up a bit in a follow-up, to move the *.install adjustments into the cockpit tests themselves. But this needs quite some iterations (backported to rhel-8.3 branch and such), I don't want to block this any further.

martinpitt and others added 2 commits January 14, 2021 09:26
Starting from the cloud image is faster, more robust, and more realistic
(using an official product) than our own virt-install bootstrap.

Teach cloudimage.bootstrap to get along with redirects, as
download.devel.redhat.com is a geolocation mirror.

Just like for centos-8-stream in commit 289ddc5 we need to tweak
the PAM config a little to match our test assumptions. Also enable
subscription-manager, it is not enabled by default on the cloud image.
These changes should eventually go into cockpit's tests themselves.

Use the same hack for cockpit-project/cockpit#15100
as on rhel-8-4.

Fixes cockpit-project#1522
@martinpitt martinpitt marked this pull request as ready for review January 14, 2021 12:33
@martinpitt
Copy link
Member Author

@jkozol, @henrywang : this flake seems to happen over and over. Do you know what's happening there?

@martinpitt
Copy link
Member Author

At this point I'll call the composer/firefox failure unrelated. This has been failing for a long time. Most recent example known to me is in osbuild/cockpit-composer#1208

@henrywang
Copy link
Contributor

@martinpitt, I have a new PR to fix this issue on branch rhel-8

@martinpitt
Copy link
Member Author

Many thanks @henrywang !

Copy link
Member

@marusak marusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@martinpitt martinpitt merged commit 3099a1b into cockpit-project:master Jan 16, 2021
@martinpitt martinpitt deleted the r83-cloud branch January 16, 2021 12:01
bcl pushed a commit to weldr/lorax that referenced this pull request Feb 8, 2021
Some of our images, like centos-8-stream, are already built from the
official cloud images instead of virt-install with LVM. More images are
going to do that soon [1][2], so fix vm.install to only do the LVM grow
steps if the image actually uses LVM.

Also adjust the comment, as commit 6ddaa5e fixed this for
RHEL images.

[1] cockpit-project/bots#1518
[2] cockpit-project/bots#1527

(cherry picked from commit 04ce221)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image refresh for rhel-8-3
4 participants