-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
images: Build rhel-8-3 from official qcow image #1527
Conversation
image-refresh in progress on 4-ci-srv-05. |
image-refresh in progress on 2-ci-srv-02. |
image-refresh rhel-8-3 done: https://github.com/cockpituous/bots/commits/image-refresh-rhel-8-3-20210107-075858 |
Some of our images, like centos-8-stream, are already built from the official cloud images instead of virt-install with LVM. More images are going to do that soon [1][2], so fix vm.install to only do the LVM grow steps if the image actually uses LVM. Also adjust the comment, as commit 6ddaa5e fixed this for RHEL images. [1] cockpit-project/bots#1518 [2] cockpit-project/bots#1527
Some of our images, like centos-8-stream, are already built from the official cloud images instead of virt-install with LVM. More images are going to do that soon [1][2], so fix vm.install to only do the LVM grow steps if the image actually uses LVM. Also adjust the comment, as commit 6ddaa5e fixed this for RHEL images. [1] cockpit-project/bots#1518 [2] cockpit-project/bots#1527 (cherry-picked from commit 04ce221)
Fixing This seems to work fine on RHEL 8.4 (as we already use the cloud image there). I want to see if that's something obvious in the PAM config, otherwise I'll just file a naughty for it. Update: Found it, we already adjusted that for centos-8-stream in 289ddc5 |
That should do it. I'll clean this up a bit in a follow-up, to move the *.install adjustments into the cockpit tests themselves. But this needs quite some iterations (backported to rhel-8.3 branch and such), I don't want to block this any further. |
Starting from the cloud image is faster, more robust, and more realistic (using an official product) than our own virt-install bootstrap. Teach cloudimage.bootstrap to get along with redirects, as download.devel.redhat.com is a geolocation mirror. Just like for centos-8-stream in commit 289ddc5 we need to tweak the PAM config a little to match our test assumptions. Also enable subscription-manager, it is not enabled by default on the cloud image. These changes should eventually go into cockpit's tests themselves. Use the same hack for cockpit-project/cockpit#15100 as on rhel-8-4. Fixes cockpit-project#1522
@jkozol, @henrywang : this flake seems to happen over and over. Do you know what's happening there? |
At this point I'll call the composer/firefox failure unrelated. This has been failing for a long time. Most recent example known to me is in osbuild/cockpit-composer#1208 |
@martinpitt, I have a new PR to fix this issue on branch |
Many thanks @henrywang ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Some of our images, like centos-8-stream, are already built from the official cloud images instead of virt-install with LVM. More images are going to do that soon [1][2], so fix vm.install to only do the LVM grow steps if the image actually uses LVM. Also adjust the comment, as commit 6ddaa5e fixed this for RHEL images. [1] cockpit-project/bots#1518 [2] cockpit-project/bots#1527 (cherry picked from commit 04ce221)
Starting from the cloud image is faster, more robust, and more realistic
(using an official product) than our own virt-install bootstrap.
Teach cloudimage.bootstrap to get along with redirects, as
download.devel.redhat.com is a geolocation mirror.
Fixes #1522