Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: Update @patternfly/patternfly, @patternfly/react-core, @patternfly/react-styles, @patternfly/react-table #931

Closed

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 24, 2022

@github-actions github-actions bot added the bot label Feb 24, 2022
@github-actions github-actions bot changed the title [no-test] package.json: Update @patternfly/patternfly, @patternfly/react-core, @patternfly/react-styles, @patternfly/react-table package.json: Update @patternfly/patternfly, @patternfly/react-core, @patternfly/react-styles, @patternfly/react-table Feb 24, 2022
…@patternfly/react-styles, @patternfly/react-table

Closes #931
@github-actions github-actions bot force-pushed the npm-update-@patternfly/patternfly-20220224-023333 branch from b83cedc to b5894a3 Compare February 24, 2022 02:33
@github-actions
Copy link
Contributor Author

Please manually check features related to these files:

package.json:    "@patternfly/patternfly": "4.179.1",
package.json:    "@patternfly/react-core": "4.198.5",
package.json:    "@patternfly/react-styles": "4.48.5",
package.json:    "@patternfly/react-table": "4.67.5",
src/ContainerCheckpointModal.jsx:import { Button, Checkbox, Form, Modal } from '@patternfly/react-core';
src/ContainerCommitModal.jsx:} from '@patternfly/react-core';
src/ContainerDeleteModal.jsx:import { Button, Modal } from '@patternfly/react-core';
src/ContainerDetails.jsx:import { DescriptionList, DescriptionListTerm, DescriptionListDescription, DescriptionListGroup, Flex, List, FlexItem, ListItem } from "@patternfly/react-core";
src/ContainerHeader.jsx:} from '@patternfly/react-core';
src/ContainerRestoreModal.jsx:import { Button, Checkbox, Form, Modal } from '@patternfly/react-core';
src/Containers.jsx:} from '@patternfly/react-core';
src/Containers.jsx:import { cellWidth } from '@patternfly/react-table';
src/Dropdown.jsx:} from '@patternfly/react-core';
src/ForceRemoveModal.jsx:import { Button, Modal } from '@patternfly/react-core';
src/ImageDeleteModal.jsx:import { Button, Checkbox, Modal, Stack, StackItem } from '@patternfly/react-core';
src/ImageDetails.jsx:import { DescriptionList, DescriptionListTerm, DescriptionListDescription, DescriptionListGroup } from "@patternfly/react-core";
src/ImageRunModal.jsx:} from '@patternfly/react-core';
src/ImageSearchModal.jsx:} from '@patternfly/react-core';
src/ImageUsedBy.jsx:import { Button, Badge, Flex, List, ListItem } from "@patternfly/react-core";
src/Images.jsx:} from '@patternfly/react-core';
src/Images.jsx:import { cellWidth } from '@patternfly/react-table';
src/Images.jsx:import '@patternfly/react-styles/css/utilities/Sizing/sizing.css';
src/Notification.jsx:import { Alert, AlertActionCloseButton } from '@patternfly/react-core';
src/PodActions.jsx:} from '@patternfly/react-core';
src/PruneUnusedImagesModal.jsx:import { Button, Checkbox, Flex, List, ListItem, Modal, } from '@patternfly/react-core';
src/PruneUnusedImagesModal.jsx:import "@patternfly/patternfly/utilities/Spacing/spacing.css";
src/app.jsx:} from '@patternfly/react-core';
src/podman.scss:@import "@patternfly/patternfly/sass-utilities/mixins.scss";

@martinpitt
Copy link
Member

Oops, this breaks the image selector in the dialog apparently?

@jelly jelly requested review from jelly and removed request for jelly February 24, 2022 11:11
@jelly jelly self-assigned this Feb 24, 2022
@jelly
Copy link
Member

jelly commented Feb 28, 2022

The issue is that clicking on "Local" now closes the select's dropdown, so something changed in the Select components behaviour. onImageSelectToggle (the onToggle) callback) is now triggered and the event handler never reaches the ToggleGroupItem's event handler.

Upstream issue opened patternfly/patternfly-react#6983

@jelly
Copy link
Member

jelly commented Apr 12, 2022

Should be unblocked as soon as there is a new PF release which includes patternfly/patternfly-react#6983

@marusak
Copy link
Member

marusak commented Apr 12, 2022

is in prerelase: patternfly/patternfly-react#7193 (comment)
Closing, so tomorrow we get refresh

@marusak marusak closed this Apr 12, 2022
@martinpitt martinpitt deleted the npm-update-@patternfly/patternfly-20220224-023333 branch July 22, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants