fix(Select): prevent footer clicks from toggling #7193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-7193.surge.sh A11y report: https://patternfly-react-pr-7193-a11y.surge.sh |
thatblindgeye
approved these changes
Apr 7, 2022
nicolethoen
approved these changes
Apr 11, 2022
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
tlabaj
reviewed
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #6983
Adds an extra check which prevents a click on the footer or footer item from toggling an open menu closed, for Selects that use
menuAppendTo(the default inline select will already prevent this toggle). If a footer item should close the menu that should be handled in its event handler.