Skip to content

Commit

Permalink
bots: Drop PhantomJS crash retries from tests-policy
Browse files Browse the repository at this point in the history
We don't currently expect something similar with Chromium.
  • Loading branch information
martinpitt authored and larskarlitski committed Dec 18, 2017
1 parent 5a5b9a1 commit 3a84866
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 45 deletions.
33 changes: 0 additions & 33 deletions bots/task/test-policy
Expand Up @@ -71,32 +71,6 @@ Journal extracted to TestMultiMachine-testFrameNavigation-fedora-i386-127.0.0.2-
Journal extracted to TestMultiMachine-testFrameNavigation-fedora-i386-127.0.0.2-2502-FAIL.log
"""

PHANTOMJS_CRASH = """
# ----------------------------------------------------------------------
# testFrameNavigation (check_multi_machine.TestMultiMachine)
#
Resource Error: Operation canceled http://127.0.0.2:9391/cockpit/@10.111.113.2/playground/test.html#/
Resource Error: Operation canceled http://127.0.0.2:9391/cockpit/@10.111.113.2/playground/test.html#/
not ok 110 testFrameNavigation (check_multi_machine.TestMultiMachine)
Traceback (most recent call last):
File "test/verify/check-multi-machine", line 202, in tearDown
MachineCase.tearDown(self)
Error: blah
"""

PHANTOMJS_RETRY = """
# ----------------------------------------------------------------------
# testFrameNavigation (check_multi_machine.TestMultiMachine)
#
Resource Error: Operation canceled http://127.0.0.2:9391/cockpit/@10.111.113.2/playground/test.html#/
Resource Error: Operation canceled http://127.0.0.2:9391/cockpit/@10.111.113.2/playground/test.html#/
# RETRY due to failure of test harness or framework
Traceback (most recent call last):
File "test/verify/check-multi-machine", line 202, in tearDown
MachineCase.tearDown(self)
Error: blah
"""

class TestPolicy(unittest.TestCase):
def testNaughtyNumber(self):
script = os.path.join(BOTS, "image-naughty")
Expand All @@ -119,13 +93,6 @@ class TestPolicy(unittest.TestCase):
(output, unused) = proc.communicate(PCP_CRASH)
self.assertEqual(output, PCP_KNOWN)

def testRetryIssue(self):
script = os.path.join(BOTS, "tests-policy")
cmd = [ script, "--offline", "verify/example" ]
proc = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE, universal_newlines=True)
(output, unused) = proc.communicate(PHANTOMJS_CRASH)
self.assertEqual(output, PHANTOMJS_RETRY)


if __name__ == '__main__':
unittest.main()
Expand Down
12 changes: 0 additions & 12 deletions bots/tests-policy
Expand Up @@ -184,18 +184,6 @@ def checkRetry(trace):

trace = normalize_traceback(trace)

# HACK: An issue in phantomjs and QtWebkit
# http://stackoverflow.com/questions/35337304/qnetworkreply-network-access-is-disabled-in-qwebview
# https://github.com/owncloud/client/issues/3600
# https://github.com/ariya/phantomjs/issues/14789
if "PhantomJS or driver broken" in trace:
return True

# HACK: A race issue in phantomjs that happens randomly
# https://github.com/ariya/phantomjs/issues/12750
if "Resource Error: Operation canceled" in trace:
return True

# HACK: Interacting with sshd during boot is not always predictable
# We're using an implementation detail of the server as our "way in" for testing.
# This often has to do with sshd being restarted for some reason
Expand Down

0 comments on commit 3a84866

Please sign in to comment.