The drop-down box disappeared where you can click and choose an item(e.g.:Installation Type,Storage on "Create VM") #13088
Comments
|
Can you be please more specific? I don't understand exactly what is missing. |
|
Sorry that I didn't describe it clearly, pls check by comparing the following 2 pictures.
|
|
Ah, I see! Thanks for the report, this is definitely broken. |
|
Yes I'm using standard fedora 30 cockpit build. |
|
@cxhlunar You also mentioned Disk Add and Storage. Does this problem also happens there? Or does it also happens outside of machines page? Let's say in Kernel Dump page -> Crash dump location -> Location dropdown. Does it also happens there? |
|
Yes, it also happens on Disk add and storage,network ... pages in "Virtual Machines" tab, I only tried on some pages in virtual machines, all have the same problem. You can refer to the following pictures. |
Thanks for response. If that also happens outside of machines page (like in kerneldump page), then it's probably a problem in our general dropdown component, thus no need to specify cockpit-machines. |
|
@cxhlunar what version of cockpit are you using? You said cockpit-machines is 205 but from the screenshots it looks like you're using a pretty old cockpit Base packages, definitely not 205 there. |
|
That is broken on distropkg images which are running |
|
Yes, the cockpit-machines is 205 but others are 196. After update all the package to the newest version ,it's ok now. |
|
Ack, thanks for confirming! |
…can be outdated base1 directory comes from cockpit-bridge, which is allowed to be in older version than the packages for plugins. In many places we use PF4 variables, (see page.css) which in older versions of patternfly.css didn't exist. Solve this issue by importing the PF4 variables inside page.css which is bundled with the extra packages' code. Fixes cockpit-project#13088 Relevant to: https://bugzilla.redhat.com/show_bug.cgi?id=1777683 Note: This fix is just a quick solution but ideally we need to get rid of all the CSS inside base1 directory because it can be terribly outdated.
|
Reopening, as Katerina just sent a PR for this to work against old versions. |
…can be outdated base1 directory comes from cockpit-bridge, which is allowed to be in older version than the packages for plugins. In many places we use PF4 variables, (see page.css) which in older versions of patternfly.css didn't exist. Solve this issue by importing the PF4 variables inside page.css which is bundled with the extra packages' code. Fixes #13088 Closes #13227 Relevant to: https://bugzilla.redhat.com/show_bug.cgi?id=1777683 Note: This fix is just a quick solution but ideally we need to get rid of all the CSS inside base1 directory because it can be terribly outdated.
Cockpit version: cockpit-machines-205.1-1.fc30.noarch
OS:Fedora30
Page: Create VM,Disk...
The drop-down box disappeared where you can click and choose an item(e.g.:Installation Type,Storage on "Create VM")
The function is still ok but may not so obvious to inform people that it's an drop-down box and user can choose items there.
Steps to reproduce
The text was updated successfully, but these errors were encountered: